Repository navigation
Fix tier folder recovery and DiskFull status after configuration reload - #19161
Open
hongzhi-gao wants to merge 5 commits into
Open
hongzhi-gao wants to merge 5 commits into
hongzhi-gao wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When every directory managed by a
FolderManageris full during DataNode startup or configuration reload, construction fails.TierManagerpreviously skipped that manager in its tier lists. Freeing disk space could then restore the DataNode toRunning, but a later TsFile allocation could still fail withIndexOutOfBoundsExceptionor select the wrong tier because the list no longer matched the configured tier levels.A successful configuration reload could also clear
ReadOnly(DiskFull)even when the same directories remained full or another disk-full source had not recovered.Changes
FolderManager. Retry a failed construction on the next access and reuse successfully constructed managers.Runningafter a successful reload. Heartbeat recovery now requires both the aggregate disk-space check and every registered disk-full recovery check to pass.Verification
python3 .github/scripts/check-it-selection.pypassed.mvn spotless:apply -o -pl integration-test -P with-integration-tests -Ddevelocity.off=truepassed.mvn verify -o -DskipUTs '-Dit.test=IoTDBDiskFullFolderRecoveryIT' -DfailIfNoTests=false -Dfailsafe.failIfNoSpecifiedTests=false -pl integration-test -am -P with-integration-tests -Ddevelocity.off=truepassed: 1 test, 0 failures, 0 errors, 0 skipped. The IT verifiesReadOnly(DiskFull)during a full-directory reload, continued read-only status after an unchanged reload, recovery toRunning, and successful TsFile creation and query.The IT raises the disk-space warning threshold to exercise the real DataNode allocation and recovery paths without physically filling the host filesystem.