Repository navigation
Fix MAD UDF exact calculation and silent approximate result - #19162
Merged
Merged
Conversation
JackieTien97
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exact MAD path has been broken since the UDF was introduced: the four getMad overloads (INT32/INT64/FLOAT/DOUBLE) create an empty DoubleArrayList and then call set(i, ...) on it. set() requires the index to be smaller
than the list size, so the first iteration always throws IndexOutOfBoundsException. Replace set() with add() and pre-size the list.
mad(x) now returns the correct value (0.78 for the reported 24-point series).