Repository navigation
Conversation
…cies LICENSE-binary had drifted from what the binary distributions actually bundle: several listed artifacts are no longer shipped (among them the javax JAXB API and runtime, which the Jakarta migration replaced), some versions were outdated, and about 60 bundled artifacts, mostly the dependencies of the REST and MQTT services, were not listed at all. The dependency section is now derived from the jars in the all-bin, edge-bin and library-udf-bin packages, including the dependencies inside the rest and mqtt jar-with-dependencies. Dual-licensed artifacts are listed under the most permissive option. licenses/ gets the texts for the newly listed licenses and loses the ones nothing refers to any more. NOTICE-binary drops Apache Commons Collections, which isn't bundled, and carries the notices from the NOTICE files of the bundled Apache-2.0 artifacts.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19164 +/- ##
============================================
- Coverage 48.53% 48.52% -0.01%
Complexity 635 635
============================================
Files 5573 5573
Lines 412215 412215
Branches 54338 54338
============================================
- Hits 200062 200047 -15
- Misses 212153 212168 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
LICENSE-binaryandNOTICE-binary(packaged asLICENSEandNOTICEin the binary distributions) no longer match what the distributions bundle. I compared them with the jars of the default packages (all-bin,edge-bin,library-udf-bin), including the artifacts insiderest-*-jar-with-dependencies.jarandmqtt-*-jar-with-dependencies.jar, and with the licenses declared in each artifact's POM.Listed, but not bundled (removed)
javax.xml.bind:jaxb-api:2.4.0-b180725.0427andorg.glassfish.jaxb:jaxb-runtime:2.3.6: nojavax.xml.bind,com.sun.xml.bindororg.glassfish.jaxbclasses are in any package since the Jakarta migration (Upgrade minimum JDK to 17 and migrate JavaX to Jakarta #17859);jakarta.xml.bind-apiis listed.com.librato.metrics:librato-java,com.librato.metrics:metrics-librato,io.dropwizard.metrics:metrics-jvm,com.bugsnag:bugsnag,com.h2database:h2-mvstore,org.jspecify:jspecify.Outdated versions (fixed)
2.16.2/2.18.6→2.18.11, moquette0.18→0.18.0; the malformedcom.google.guava.guavaandio.airlift.airlinecoordinates are corrected.Bundled, but not listed (added)
jakarta.ws.rs-api,mimepull,javassist,snakeyaml,jackson-dataformat-yaml,jackson-datatype-jsr310,commons-lang3.reload4j,slf4j-reload4j,HikariCP,commons-codec, netty kqueue/tcnative.lib/: Ratis, reactor, micrometer, JNA,checker-qual,HdrHistogram,LatencyUtils,Java-WebSocket,cglib, Guava's annotation/companion artifacts,commons-csv,commons-pool2,airlift:units,jakarta.validation-apiand further netty modules.Dual-licensed artifacts are listed under the most permissive option (Jetty, JNA, javassist and moquette under Apache License 2.0; logback, Jakarta APIs, HK2 and Jersey under EPL 2.0; HdrHistogram under CC0). The Jersey lines name the third-party code that
jersey-common(parts of Guava, JSR-166) andjersey-server(ASM) repackage.licenses/NOTICE-binaryjackson-corebundles FastDoubleParser (MIT, with portions under the Boost Software License 1.0, MIT and BSD 2-Clause) and Schubfach (MIT); its LICENSE-binary line says so, and the license texts from the jackson-core jar are inlicenses/.Result: 117 entries, exactly the 117 third-party artifacts in the packages (verified with a fresh
mvn clean package -pl distribution -am -DskipTestson this branch;LICENSEandNOTICEin all three zips are identical toLICENSE-binaryandNOTICE-binary,apache-rat:checkpasses).Not part of this PR: the AINode and C++ client packages, which have their own license files.
🤖 Generated with Claude Code