Repository navigation
Conversation
* Use column header constants in pipe user assertions * Use canonical column names in pipe privilege assertions (cherry picked from commit 0ed7549)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #19131 (commit 0ed7549) to
dev/1.3, based on 876b22b.Reuse
ColumnHeaderConstant.USERin bothIoTDBPipePermissionITuser-header assertions. Keep the existing one-columnLIST USERresults, expected rows, and assertion behavior on this branch.Compatibility adaptations: use the
dev/1.3test path andorg.apache.iotdb.db.queryengine.common.headerpackage. The source user-column lookup maps to the existingtestWithConnectoruser-header assertion on this branch. BothIoTDBPipeInclusionITheaders already use the branch's canonical constants, includingPATHfor privilege paths, so they need no changes. Do not introduce the newer user-ID column or privilege scope format.Validation:
mvn spotless:apply -P with-integration-tests -pl integration-test(restricted to the changed Java file) andgit diff --checkpassed. A source comparison verified that expanding the twoUSERreferences to their declared value reproduces the base Java tokens exactly, apart from the added import and formatting. Full compilation and integration tests were not run for this test-only constant substitution. No new tests were added.