Repository navigation
Conversation
Collaborator
Author
|
Initial self-review summary
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
Prevent tree-model LAST cache initialization, update, and invalidation from repopulating the schema cache after schema deletion. Schema cache population remains on the protected schema acquisition and creation paths.
Available incident logs do not establish that a concurrent LAST query triggered the reported symptom.
Known limitation and follow-up
An older LAST query can still publish its result to the last-value cache after a same-name schema is dropped and recreated. Complete protection requires capturing a schema-generation token during planning, propagating it through distributed plan serialization, and validating it during cache initialization and asynchronous completion on every DataNode and Region.
That path crosses schema metadata lifecycle, distributed plan transport, concurrent cache state, and multi-node/multi-Region tests. It is substantially broader than separating schema-cache writes from last-cache updates, so it is deferred to a dedicated follow-up.
Changed paths
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/fetcher/cache/TableDeviceCacheEntry.javaiotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/fetcher/cache/TableDeviceSchemaCache.javaiotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/fetcher/cache/TreeDeviceSchemaCacheManager.javaiotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/last/AbstractUpdateLastCacheOperator.javaiotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertRowNode.javaiotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/InsertTabletNode.javaiotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.javaiotdb-core/datanode/src/test/java/org/apache/iotdb/db/metadata/cache/TreeDeviceSchemaCacheManagerTest.javaVerification
mvn spotless:apply -P with-integration-tests -pl iotdb-core/datanodepassed.git diff --checkpassed.