Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #19182 +/- ##
=========================================
Coverage 48.80% 48.80%
Complexity 674 674
=========================================
Files 5574 5574
Lines 412836 412893 +57
Branches 54448 54457 +9
=========================================
+ Hits 201480 201511 +31
- Misses 211356 211382 +26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Follow-up review summary
Fixed the two behavioral issues raised in this follow-up: all authorized TTL intersections now transfer as separate plans, and database-compatible TTL paths retain their descendant semantics through both Pipe-pattern and privilege filtering. Narrowed plans clear the database flag; ordinary exact device TTL paths remain exact. Split events preserve source order and report progress only on the final fragment, including snapshot parsing and privilege-check retries. Validation: 61 distinct focused unit tests passed, and all newly added tests ran locally. Both locales rebuilt the required 29-project dependency closure from clean source; Chinese test compilation passed. An initial run exposed three containment failures; after restoring the requested-scope guard for every TTL intersection, a clean ConfigNode rebuild and all 13 affected privilege tests passed. The other 48 focused tests had already passed. Spotless formatting passed. Repository-wide English and Chinese reactor validation remains incomplete: those attempts were stopped during dependency preparation. Remote CI checks were queued or running when inspected; they were not awaited. This round made behavioral fixes, so the PR remains draft for a fresh independent review of the complete current diff. |
10bb7db to
2e5461c
Compare
|
Independent re-review passed; no fixes were needed.
Reviewed the complete current diff and relevant context, with particular attention to TTL authorization intersections, database TTL compatibility, split-event ordering and progress, snapshot parsing, privilege retries, and the shared source API's consumers. No actionable issues were found. Validation: a clean 29-project dependency reactor build passed with build caching disabled (499 goals executed). All 37 tests in Repository-wide builds, the Chinese locale, and integration tests were not run in this session. Remote CI for the rebased head is separate and has not been awaited. There are no incomplete branch-update steps. |
|



Pipe metadata privilege filtering can retain an ancestor path after an unmatched authorization prefix and drop valid TTL intersections. Database-compatible TTL plans can also lose their descendant scope during filtering.
isDataBase=true) as its descendant scope when applying both the Pipe pattern and privilege filters. Preserve the database flag when the scope is unchanged; clear it when narrowing to a device path or prefix. Ordinary exact device TTL paths keep their exact semantics. Set and unset TTL values are preserved.Validation: