Repository navigation
Conversation
Caideyipi
marked this pull request as draft
November 9, 2026 08:15
Caideyipi
marked this pull request as ready for review
November 9, 2026 09:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing a table TTL from
9223372036854775807toINFwas treated as unchanged because both resolve toLong.MAX_VALUE. Comparing the stored TTL property now persists the transition and makesSHOW TABLESreportINF. This also coversDEFAULTwhen the database default is infinite while preserving no-op behavior for an already infinite TTL.Regression coverage checks finite-to-maximum-to-infinite transitions,
DEFAULTresolving to infinity, original property preservation before commit, persisted ConfigNode state, and repeated infinite TTL updates.The CI follow-up restores the missing flush-listener collection used by
WALNodeTest.testDeleteOutdatedFilesafter syncing the target branch. It retains the existing writes and success assertions.Validation: Spotless and the IT selection check passed. The ConfigNode procedure test class passed (3 tests), and the new regression fails against the original implementation. The focused integration method passed under TableSimpleIT and under TableClusterIT settings using direct JUnit (1 ConfigNode, 3 DataNodes). The direct Maven TableClusterIT invocation was blocked before test execution by dependency resolution.
CI follow-up validation: DataNode Spotless passed, and the local Surefire run of
WALNodeTest#testDeleteOutdatedFilespassed (1 test, 0 failures, 0 errors, 0 skipped) after test-source compilation. The remote Maven attempt was blocked by build-plugin resolution. Full dual-locale compilation has not been run.