Repository navigation
Fix WALNodeTest compilation after explicit WAL rolling - #19189
Merged
Merged
Conversation
Caideyipi
marked this pull request as ready for review
November 9, 2026 06:11
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19189 +/- ##
============================================
+ Coverage 48.78% 48.80% +0.01%
Complexity 674 674
============================================
Files 5574 5574
Lines 412528 412785 +257
Branches 54404 54441 +37
============================================
+ Hits 201270 201459 +189
- Misses 211258 211326 +68 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



WALNodeTest#testDeleteOutdatedFilesstill referenceswalFlushListenersafter #17921 removed the list and its collection code, preventing DataNode test compilation onmaster.Remove the obsolete listener loop. The explicit
walNode.rollWALFile()already waits for its roll listener; the WAL-consumption wait and file-existence/deletion assertions remain in place.Validation:
mvn spotless:apply -P with-integration-tests -pl iotdb-core/datanode -opassed.git diff --checkpassed.WALNode#rollWALFileimplementation and the remaining listener references.