Skip to content

Fix WALNodeTest compilation after explicit WAL rolling - #19189

Merged
Caideyipi merged 1 commit into
masterfrom
codex/fix-walnode-test-compilation-20261109
Nov 9, 2026
Merged

Caideyipi merged 1 commit into
masterfrom
codex/fix-walnode-test-compilation-20261109

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

WALNodeTest#testDeleteOutdatedFiles still references walFlushListeners after #17921 removed the list and its collection code, preventing DataNode test compilation on master.

Remove the obsolete listener loop. The explicit walNode.rollWALFile() already waits for its roll listener; the WAL-consumption wait and file-existence/deletion assertions remain in place.

Validation:

  • mvn spotless:apply -P with-integration-tests -pl iotdb-core/datanode -o passed.
  • git diff --check passed.
  • Checked the synchronous WALNode#rollWALFile implementation and the remaining listener references.
  • Maven test compilation and WAL tests were not rerun for this deletion-only change.

@Caideyipi
Caideyipi marked this pull request as ready for review November 9, 2026 06:11
@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2026

Copy link
Copy Markdown

@Caideyipi
Caideyipi merged commit 947063c into master Nov 9, 2026
40 of 41 checks passed
@Caideyipi
Caideyipi deleted the codex/fix-walnode-test-compilation-20261109 branch November 9, 2026 06:15
@codecov

codecov Bot commented Nov 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.80%. Comparing base (db0a9b4) to head (defd9ae).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #19189      +/-   ##
============================================
+ Coverage     48.78%   48.80%   +0.01%     
  Complexity      674      674              
============================================
  Files          5574     5574              
  Lines        412528   412785     +257     
  Branches      54404    54441      +37     
============================================
+ Hits         201270   201459     +189     
- Misses       211258   211326      +68     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant