Repository navigation
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #19190 +/- ##
============================================
- Coverage 48.80% 48.80% -0.01%
Complexity 674 674
============================================
Files 5574 5574
Lines 412836 412926 +90
Branches 54448 54459 +11
============================================
+ Hits 201480 201517 +37
- Misses 211356 211409 +53 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Schema-file initialization, shutdown, and positional writes can leave incomplete data or open resources after an I/O failure. This change writes the initial header immediately, completes short header and page writes, and attempts all cleanup steps while preserving the original exception.
Failure examples
IOExceptionIOExceptionis propagated unchanged. The page stays dirty, and a retry starts from the page's original file offset with the full page.SchemaFile.clear()recreates the file and it is reopened before a later header updateSchemaFile.close()Validation
git diff --checkpassed.SchemaPageTestandSchemaFileTestpassed, with 26 tests, 0 failures, 0 errors, and 0 skipped. All newly added tests were run locally.clean test-compilepassed for the 28 relevant reactor modules. This does not establish that the full repository compiles with the Chinese locale.This PR has:
Key changed classes
SchemaFile,SchemaPage,PageIOChannel,PageManager