Repository navigation
Fix snapshots of deleted TsFile resources during DataNode removal - #19192
Open
hongzhi-gao wants to merge 2 commits into
Open
hongzhi-gao wants to merge 2 commits into
hongzhi-gao wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Taking a snapshot captures the TsFile resource lists before closing working files. If an unflushed row has been deleted, closing its empty file marks the resource DELETED and removes the file, but the snapshot's copied list still retains it. Snapshot creation then attempts to capture files that no longer exist. Separately, a missing hard-link source is silently ignored, and deserializing a missing resource file can throw a NullPointerException instead of the declared IOException.
No snapshot format or RPC changes.
Validation
Executed against base
c6e229aef50608cb67bfb4fd94717d05f4ef3d0f:IoTDBSnapshotTest,TsFileResourceTest, andDataRegionTest#testSnapshotAfterDeletingUnflushedData: 20 passed, 1 existing manual multi-disk test skipped.with-zh-localepassed..Review
Key classes:
SnapshotTaker,TsFileResource.