Repository navigation
Conversation
Wake an existing idle prefetch task after an empty poll so replicated WAL entries can be discovered without another local write. Preserve initialization, seek, lifecycle and executor-binding guards. Add a regression covering delivery and acknowledgement without advancing the local WAL cursor.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19194 +/- ##
============================================
- Coverage 48.80% 48.79% -0.01%
Complexity 674 674
============================================
Files 5574 5574
Lines 412836 412845 +9
Branches 54448 54452 +4
============================================
- Hits 201480 201458 -22
- Misses 211356 211387 +31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Replicated WAL entries can arrive after a subscription prefetch worker becomes idle without advancing the local WAL search index or entering the realtime queue. Repeated polls can then stay empty until another event wakes the worker.
Wake a bound idle prefetch worker after an empty poll, with a per-queue 100 ms limit enforced by a monotonic-clock CAS. Preserve the initialization, seek, close, and executor-binding guards. Add regression tests for late remote-entry delivery and acknowledgement with zero local WAL gap, and for suppression immediately before the wakeup interval and grant at its boundary.
Validation
At commit
3a343faaff65424068f357819ecfe97c8a41ca9d:ConsensusPrefetchingQueueSeekTest: 11 tests passed.git diff --checkpassed.The full test suite and distributed integration tests have not been run on this commit.
This PR has:
Key changed/added classes
ConsensusPrefetchingQueueConsensusPrefetchingQueueSeekTest