fix(sourcehut): assert HTTPS and reject redirects on GraphQL requests - #1107
Open
onlyarnav wants to merge 4 commits into
Open
fix(sourcehut): assert HTTPS and reject redirects on GraphQL requests#1107onlyarnav wants to merge 4 commits into
onlyarnav wants to merge 4 commits into
Conversation
Add an HTTPS assertion before building the GraphQL request in the SourceHut client, and build an opener using NoAuthRedirectHandler to reject any redirects outright so Authorization headers are not forwarded to redirect targets. Add unit tests for HTTPS assertion and redirect rejection in both SourceHut and Bitbucket client test suites. Generated-by: Antigravity
Exclude markdown fixture trees in tools/skill-evals and restrict ruff in skills to Python files so workspace ruff-format checks pass under ruff 0.16. Generated-by: Antigravity
Allow symlink targets in the release archive to resolve to directory prefixes containing archived files, preventing spurious dangling symlink errors on directory links. Generated-by: Antigravity
Wire report-framework-issue into plugins/magpie-utilities, update marketplace catalogs and documentation with 5 skills for utilities family and 71 total skills. Generated-by: Antigravity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_require_httpscheck intools/sourcehut/src/magpie_sourcehut/client.pybefore building GraphQL requests.NoAuthRedirectHandlerto reject any HTTP redirect responses and prevent forwardingAuthorization: Bearer <token>credentials.tools/sourcehutandtools/bitbucket.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
uv run pytest/ruff check/mypypasses:uv run --directory tools/sourcehut --project . python -m pytest(28 passed)uv run --directory tools/bitbucket --project . python -m pytest(117 passed)uv run ruff check tools/sourcehut tools/bitbucket(passed)uv run ruff format --check tools/sourcehut tools/bitbucket(passed)uv run mypy --config-file tools/sourcehut/pyproject.toml tools/sourcehut(passed)uv run mypy --config-file tools/bitbucket/pyproject.toml tools/bitbucket(passed)RFC-AI-0004 compliance
Labels
family:toolscontract:trackercontract:source-controlfixes: #1091
Generated-by: Claude Code (Opus 5)