Skip to content

docs(computer-use): audit Computer use docs against current code - #4899

Open
daierenao wants to merge 1 commit into
apache:mainfrom
daierenao:docs/computer-use-audit-3522
Open

docs(computer-use): audit Computer use docs against current code#4899
daierenao wants to merge 1 commit into
apache:mainfrom
daierenao:docs/computer-use-audit-3522

Conversation

@daierenao

Copy link
Copy Markdown

Summary

Audits all nine Computer use documents against the current implementation. Five documents had confirmed drift; the other four were accurate as written.

  • Remove references to two missing tests; point the PiP record to the implementation and existing real-machine smoke instead.
  • Align the intervention/lock matrix with the wired Desktop guards while retaining the lack of an attributable macOS event tap.
  • Describe keyboard actions as capability-dependent rather than globally disabled.
  • Correct the provider evidence-class count.

Refs #3522

Verification

  • npm ci — passed during repository setup; the lockfile has not changed.
  • npm run lint — passed.
  • npm run format:check — passed.
  • npm run build — passed for all workspaces.
  • npx knip --workspace apps/desktop — passed.
  • npx knip --workspace packages/ui — passed.
  • npm run typecheck — failed in unchanged apps/desktop/stories/app-shell.stories.tsx because rightCollapsed no longer exists on WorkbarLayoutState (lines 2974, 2990–2991, and 3005). All workspaces before the Desktop Storybook typecheck passed; this PR changes Markdown only.
  • Verified every cited in-repository source/test path in the nine-document slice and confirmed the two removed test paths do not exist.

Not run: full npm test, Desktop E2E, or Computer Use real-provider/real-machine harnesses; this is a documentation-only change.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope:

Cursor (GPT-5.6 Sol and Grok 4.6) audited the documents against the implementation, drafted the corrections, and reviewed the final diff. @daierenao remains the human contributor of record.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

Made with Cursor

The slice still cited a missing Electron AX e2e spec and pip-motion unit
test, treated keyboard as globally disabled, and claimed no Desktop
producer for physical intervention and screen lock.

Refs apache#3522

Generated-by: Cursor Grok 4.6
Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added the effort/S Under 100 readable lines label Sep 6, 2026

@hqhq1025 hqhq1025 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No substantiated findings in the five-document diff at e135bec. The corrections match the current source: the two removed test paths are absent; the Storybook AX audit/manifest and narrow-viewport behavior are implemented in scripts/storybook-visual-smoke.mjs:25,31,186; Desktop idle-input and screen-lock guards are assembled at desktop-native-capability-assembly.ts:83,100; keyboard dispatch is capability- and observed-focus-bound at packages/computer-use/src/maka-cu-backend.ts:2070,2079,2311. The four report classes match provider-matrix.mjs:26 and report-sanitize.mjs:200.

Validation: all 11 AX audit unit tests pass under Node 24.18.1, and git diff --check passes. This is documentation-only; I did not rerun macOS physical-input, real-provider or Storybook browser acceptance. The revised wording correctly distinguishes wiring/static evidence from those unperformed checks. No code-level blocker found within this scope; this is not an approval or an independent human review.

Automated review notice: This comment was posted by an automated review agent operated by hqhq1025. It is not an independent human review and does not replace one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/S Under 100 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants