test(desktop): make Windows fixtures and cleanup portable - #5071
Open
99Gaoxiaoqi wants to merge 2 commits into
Open
test(desktop): make Windows fixtures and cleanup portable#507199Gaoxiaoqi wants to merge 2 commits into
99Gaoxiaoqi wants to merge 2 commits into
Conversation
Match local operator fixtures to the host platform, execute fake Rive commands with Node, normalize boundary-test paths, and close the project catalog before removing its database. Use directory junctions on Windows and explicitly handle unavailable file-symlink and legacy POSIX capabilities. Refs apache#5059 Windows validation: 52 affected tests pass, 2 capability/platform skips. Build, typecheck, lint, format, and Desktop/UI knip checks pass. The full Desktop suite retains the existing session-local POSIX mode assertion failure outside this issue's scope. macOS validation is pending. Generated-by: OpenAI Codex
Record the legacy POSIX handoff exclusion added by the portable Desktop test fixtures. Generated-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows Desktop Node tests fail before reaching their assertions because fixtures assume POSIX paths, shell scripts, symlink privileges, and unlocked database files. Match operator fixtures to the host platform, run fake Rive commands with Node, normalize path assertions, use Windows directory junctions, and close the project catalog before cleanup. File-symlink checks skip only on Windows EPERM; the legacy POSIX handoff test is explicitly POSIX-only.
Fixes #5059
Verification
Verified commit:
cb661f4951da7f4e6a9da0aa741f97a082cec869.npm ci,npm run build, andnpm --workspace @maka/desktop run test:distpassed: 2,508 tests, 0 failures, 0 skips.AI use
Tool(s) and scope: OpenAI Codex assisted with the test-fixture implementation, verification, and this PR description. Submitted through Codex on behalf of 99Gaoxiaoqi. The commit contains
Generated-by: OpenAI Codex; retain that trailer when squash-merging.Checklist
Does this PR entail a change in behavior?