fix(mcp): advertise Apache identity in OAuth DCR - #5073
Open
wutongyuonce wants to merge 1 commit into
Open
Conversation
Point client_uri at the Apache product homepage and set software_id to the running clientName so TUI is no longer registered as desktop. Refs apache#5072 Generated-by: Pi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCP OAuth dynamic client registration still advertised the pre-Apache GitHub org and always set
software_idtomaka-desktop. Consent screens and IdP policy that key off those fields therefore saw a stale identity.This PR points
client_uriathttps://maka.apache.org/en/and setssoftware_idto the runningclientName(maka,maka-tui, ormaka-desktop). Tokens, redirect URIs, and the authorization flow are unchanged.Fixes #5072
Verification
npm --workspace @maka/mcp run build && node --test packages/mcp/dist/__tests__/oauth.test.js— 39 passedlint/format:check/ fullnpm testReview
Independent Codex review (read-only) found no must-fix issues. Follow-up: unit test now also locks
redirect_urisandgrant_types. Skipped extra desktop/TUI injection tests — caller chain already passes distinctclientNamevalues.AI use
Select exactly one:
Tool(s) and scope: Pi implemented the metadata change, tests, issue, and PR text. Codex ran a read-only review.
Checklist
Does this PR entail a change in behavior?