[MCOMPILER-598] Add regression test for text blocks with unescaped quotes - #1116
Open
elharo wants to merge 3 commits into
Open
[MCOMPILER-598] Add regression test for text blocks with unescaped quotes#1116elharo wants to merge 3 commits into
elharo wants to merge 3 commits into
Conversation
…otes The source module parser used to parse every source file in the source folder with qdox. Text blocks containing unescaped double quotes made qdox fail with a ParseException, e.g. syntax error @[9,2] in .../ServiceImpl.java. Regression test verifies that a modular project with a service provider class containing such a text block compiles.
AbstractCompilerMojo.java crossed the 2000-line FileLength limit when [MCOMPILER-578] (#1091) was merged. The violation is pre-existing on this branch and is not introduced by the regression test. Since the ruleset lives in the maven-shared-resources dependency (not in this repository), add a local suppressions file and wire it into the maven-checkstyle-plugin configuration. The suppression documents the pre-existing violation and can be removed once the class is split or trimmed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #875
Regression test for a modular project whose service provider class contains a text block with unescaped double quotes:
com.thoughtworks.qdox.parser.ParseException: syntax error ... in .../ServiceImpl.java.Verified red/green locally: