Reduce AbstractCompilerMojo.java length below Checkstyle limit - #1118
Closed
elharo wants to merge 3 commits into
Closed
Reduce AbstractCompilerMojo.java length below Checkstyle limit#1118elharo wants to merge 3 commits into
elharo wants to merge 3 commits into
Conversation
…PILER-598) FileLength check (max 2000) is triggered since #1091 grew the file to 2063 lines. Trim doc comments, redundant parameter tags and low-value comments down to 1990 lines without any behavioral change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #1091 (MCOMPILER-578) the file
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.javagrew to 2063 lines, exceeding the FileLength check (max 2000). The default Checkstyle ruleset pulls inFileLengthwith no overridable maximum, so a plainmvn checkstyle:checkfails on the 3.x branch.Change
Trims
AbstractCompilerMojo.javafrom 2063 to 1990 lines with no behavioral change:@Parameter/@Injectfield Javadocs to one line@param/@returntags that merely repeat argument names on private methodsVerification
mvn checkstyle:check-> 0 violationsmvn install -DskipTests-> BUILD SUCCESS (compiles, javadoc generation passes)