Reenable HTTP3 based tests as ASF Jenkins Linux nodes are upgraded - #2064
Merged
Conversation
kwin
force-pushed
the
bugfix/test-http3-on-asf-jenkins
branch
from
August 21, 2026 09:20
ab996c6 to
2a33f5a
Compare
kwin
marked this pull request as ready for review
August 21, 2026 09:29
kwin
added
skip-changelog
gnodet
approved these changes
Aug 21, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Clean, safe removal of the HTTP/3 test skip workaround (INFRA-28128 / jetty-quiche-native#180). The assumeFalse(supportsHttp3()) guard and its unused assumeFalse import are correctly removed. Subclass overrides in ApacheTransporterTest, UrlTransporterTest, and JdkTransporterTest are unaffected. Low risk — if the Jenkins upgrade didn't fully resolve GLIBC compatibility, tests would fail visibly on CI.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of Guillaume Nodet
olamy
approved these changes
Aug 21, 2026
olamy
left a comment
olamy
left a comment
Member
There was a problem hiding this comment.
Sounds great! Good to see usage of Jetty http3 client
Generated by a real human
Olivier on behalf of Olivier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/INFRA-28128
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.