Repository navigation
Full proof that use read operation is working - #82
Merged
Merged
Conversation
the-thing
requested review from
elecharny
and
a balanced review from Copilot
and removed request for
Copilot
October 12, 2026 06:54
Copilot stopped reviewing on behalf of
the-thing due to an error
October 12, 2026 06:59
the-thing
force-pushed
the
set-read-operation-proof
branch
from
October 13, 2026 06:37
6a2500c to
2253e86
Compare
Contributor
|
Hi Marcin,
I'm pretty sure your last merge didn't make it to the coming version
(2.2.10) that I built last night.
No worries, we will most certainly cut a new version in a few weeks with
some more fixes.
Just wanted to let you know.
Regards,
Cordialement,
Emmanuel Lécharny
www.worteks.com <http://www.iktek.com>
Le mer. 14 oct. 2026 à 07:40, Marcin L ***@***.***> a écrit :
… Merged #82 <#82> into 2.2.X.
—
Reply to this email directly, view it on GitHub
<#82?email_source=notifications&email_token=AAWJQFIGS3BWPEUDNBT4K3D5T4GTBA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMZRHE3TKOJWGA3DFJTSMVQXG33OWBZGK5TJMV3V64TFOF2WK43UMVSKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#event-33197596062>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWJQFPSQYXCNXVOTO7QP335T4GTBAVCNFSNUABCKJSXA33TNF2G64TZHMZDANRTGY3DWSLTON2WKOZVHAYDSMJTGIYTKNVBOYBA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Member
Author
|
Yes. I noticed. No worries, because these are just tests proving that DIRMINA-777 was fixed before, so really nothing to release here. |
Contributor
|
Great!
I wasn't able to check the commit, being on my phone atm.
Thanks!
Regards,
Cordialement,
Emmanuel Lécharny
www.worteks.com <http://www.iktek.com>
Le mer. 14 oct. 2026 à 12:11, Marcin L ***@***.***> a écrit :
… *the-thing* left a comment (apache/mina#82)
<#82 (comment)>
Yes. I noticed. No worries, because these are just tests proving that
DIRMINA-777 was fixed before, so really nothing to release here.
—
Reply to this email directly, view it on GitHub
<#82?email_source=notifications&email_token=AAWJQFIRAMETWHRLYSK2GDD5T5GNFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMJWGU4TQMRWGEYKM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6165982610>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWJQFOHD5B6ANHAOYN24BD5T5GNFAVCNFSNUABCKJSXA33TNF2G64TZHMZDANRTGY3DWSLTON2WKOZVHAYDSMJTGIYTKNVBOYBA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewritten tests for setUseReadOperation that prove DIRMINA-777 is working (unless I missed something).
Enabled Java 17 for tests to make use
java.util.concurrent.atomic.AtomicBoolean#setOpaque