MINIFICPP-2852 Implement LMDB based flow file repository - #2203
Open
lordgamez wants to merge 2 commits into
Open
MINIFICPP-2852 Implement LMDB based flow file repository#2203lordgamez wants to merge 2 commits into
lordgamez wants to merge 2 commits into
Conversation
lordgamez
marked this pull request as ready for review
June 24, 2026 15:12
lordgamez
force-pushed
the
MINIFICPP-2852
branch
from
June 25, 2026 14:57
d17e0e6 to
d0936f1
Compare
8 tasks
lordgamez
force-pushed
the
MINIFICPP-2849
branch
from
August 12, 2026 08:27
92f698e to
3653c3b
Compare
lordgamez
force-pushed
the
MINIFICPP-2852
branch
from
August 12, 2026 08:27
d0936f1 to
c04e43f
Compare
8 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Implements an LMDB-backed FlowFile repository and extracts shared LMDB database operations for reuse.
Changes:
- Adds configurable LMDB FlowFile persistence and recovery.
- Introduces a shared LMDB wrapper.
- Updates LMDB content repository and tests.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
Configuration.h |
Adds FlowFile LMDB size property. |
Configuration.cpp |
Registers property validation. |
LmdbStreamTests.cpp |
Adapts stream tests to the wrapper. |
LmdbFlowFileRepositoryTests.cpp |
Tests the new repository. |
LmdbContentSessionTests.cpp |
Updates repository namespace. |
LmdbContentRepositoryTests.cpp |
Updates namespace and logging tests. |
LmdbWrapper.h |
Declares shared LMDB operations. |
LmdbWrapper.cpp |
Implements shared LMDB operations. |
LmdbStream.h |
Integrates streams with the wrapper. |
LmdbStream.cpp |
Delegates stream persistence to the wrapper. |
LmdbFlowFileRepository.h |
Declares the FlowFile repository. |
LmdbFlowFileRepository.cpp |
Implements persistence, recovery, and deletion. |
LmdbContentRepository.h |
Refactors content storage around the wrapper. |
LmdbContentRepository.cpp |
Delegates content operations to the wrapper. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lordgamez
force-pushed
the
MINIFICPP-2852
branch
from
August 13, 2026 12:29
c04e43f to
3ba0604
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2852
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.