NIFI-15717: Add QueryCassandra processor and CassandraSessionProvider Controller Service. by vishal-firgan-ksolves · Pull Request #11032 · apache/nifi

vishal-firgan-ksolves · 2026-03-23T08:16:42Z

…r Service.

Summary

This PR introduces the QueryCassandra processor for Apache NiFi 2.x, enabling integration with Cassandra using the latest DataStax Java driver.

Components Added

QueryCassandra processor for executing CQL queries
CassandraSessionProvider Controller Service for managing connections

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Apache NiFi Jira issue created

Pull Request Tracking

Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

Pull Request based on current revision of the main branch
Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

Build completed using ./mvnw clean install -P contrib-check
- JDK 21
- JDK 25

Licensing

New dependencies are compatible with the Apache License 2.0 according to the License Policy
New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

Documentation formatting appears as expected in rendered files

exceptionfactory

Thanks for putting together this down-scoped pull request. I'm planning to take a closer look soon, but it provides a good basis for initial review.

One initial element to consider is the data type handling in the AbstractCassandraProcessor. It seems like it would be best to pull that out to a separate interface and implementation, perhaps several depending on the details. The general goal there is to decouple type conversion from the Processor itself, so that it can be used in composition, rather than by extension in other Cassandra Processors.

vishal-firgan-ksolves · 2026-03-27T14:20:07Z

@exceptionfactory I’ve implemented the changes to decouple type conversion from AbstractCassandraProcessor into a new CassandraTypeConverter interface with StandardCassandraTypeConverter as its implementation.
Please review the changes.

exceptionfactory

Thanks for the initial update @vishal-firgan-ksolves.

On a more substantive review, I noticed a large number of significant design and implementation issues. I highlighted a number of them, but based on this review, this will require substantial rework before going forward. I'm not in a position to provide direction on every detail, so this may need to be revisited down the road.

exceptionfactory · 2026-04-03T19:50:36Z

+        <dependency>
+            <groupId>org.apache.nifi</groupId>
+            <artifactId>nifi-cassandra-processors</artifactId>
+            <version>2.9.0-SNAPSHOT</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.nifi</groupId>
+            <artifactId>nifi-cassandra-services</artifactId>
+            <version>2.9.0-SNAPSHOT</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.nifi</groupId>
+            <artifactId>nifi-cassandra-services-api</artifactId>
+            <version>2.9.0-SNAPSHOT</version>
+        </dependency>


Component JAR dependencies do not belong in the nifi-assembly module.

exceptionfactory · 2026-04-03T19:51:56Z

+        <groupId>org.apache.nifi</groupId>
+        <artifactId>nifi-cassandra-bundle</artifactId>
+        <version>2.9.0-SNAPSHOT</version>
+        <relativePath>../pom.xml</relativePath>


This relative path is not needed and should be removed.

exceptionfactory · 2026-04-03T19:53:24Z

+        } else if (type.equals(DataTypes.TIME)) {
+            return Long.class;
+        } else if (type.equals(DataTypes.BLOB)) {
+            return java.nio.ByteBuffer.class;


Qualified class name references should be avoided in favor of standard imports.

exceptionfactory · 2026-04-03T19:54:08Z

+ */
+public abstract class AbstractCassandraProcessor extends AbstractProcessor {
+
+    static final PropertyDescriptor CONNECTION_PROVIDER_SERVICE = new PropertyDescriptor.Builder()


Property Descriptor variables should align closely with the property name, such as CASSANDRA_CONNECTION_PROVIDER.

exceptionfactory · 2026-04-03T20:03:19Z

+   See the License for the specific language governing permissions and
+   limitations under the License.
+
+APACHE NIFI SUBCOMPONENTS:


This license file is incorrect and contains references that are not applicable.

exceptionfactory · 2026-04-03T20:04:24Z

+            .build();
+
+    static final PropertyDescriptor READ_TIMEOUT_MS = new PropertyDescriptor.Builder()
+            .name("Read Timeout (ms)")


This convention is not correct, duration validators and syntax should be used.

exceptionfactory · 2026-04-03T20:04:53Z

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.nifi.service.CassandraSessionProvider


This should be changed to a cassandra subpackage.

exceptionfactory · 2026-04-03T20:05:25Z

+/**
+ * Mock Cassandra processor for testing CassandraSessionProvider
+ */
+public class MockCassandraProcessor extends AbstractProcessor {


What is the reason for this class, as opposed to just using Mockito?

exceptionfactory · 2026-04-03T20:06:06Z

+            <dependency>
+                <groupId>org.lz4</groupId>
+                <artifactId>lz4-java</artifactId>
+                <version>${lz4-java.version}</version>
+            </dependency>


This dependency is banned.

vishal-firgan-ksolves · 2026-04-06T12:48:32Z

@exceptionfactory ,
Thanks for the detailed review and for pointing out the design and implementation issues.

I understand that the current approach needs significant rework. The initial implementation was based on patterns from NiFi Cassandra processors (around the 1.28 codebase), but I see that these are no longer aligned with current expectations.

I will revisit the implementation and refactor it to better align with current NiFi standards and patterns, and follow up with an updated version.

vishal-firgan-ksolves · 2026-04-16T07:41:28Z

@exceptionfactory
I have addressed all review feedback, including refactoring processors and services, and aligning the implementation with current NiFi standards. The implementation has been updated to align with existing NiFi bundle patterns and project structure. Please review the updated changes.

…r Service.

vishal-firgan-ksolves · 2026-05-12T09:52:04Z

@exceptionfactory
Following up on the recent updates. The implementation has been refactored to align with current NiFi patterns based on earlier feedback. When you get a chance, could you please take another look.

exceptionfactory

Thanks for your patience on this pull request @vishal-firgan-ksolves. I have not reviewed all the changes given a number of other issues lately, but I highlighted an additional set of changes needed. This may require more work.

exceptionfactory · 2026-08-12T21:11:58Z

+                    TLS/SSL connections to the Cassandra cluster.
+                    """)
+            .required(false)
+            .identifiesControllerService(SSLContextService.class)


This should use the more generic SSLContextProvider interface.

Suggested change

.identifiesControllerService(SSLContextService.class)

.identifiesControllerService(SSLContextProvider.class)

exceptionfactory · 2026-08-12T21:12:20Z

+            .description("Connection timeout. 0 means no timeout. If no value is set, the underlying default will be used.")
+            .required(false)


A default value should be provided.

exceptionfactory · 2026-08-12T21:12:29Z

+            .description("Read timeout. 0 means no timeout. If no value is set, the underlying default will be used.")
+            .required(false)


A default value should be provided

exceptionfactory · 2026-08-12T21:13:02Z

+                    Specifies the compression type used for transport-level requests and responses.Note that Snappy
+                    compression is not supported when using Protocol V5.
+                    """)
+            .required(false)


A property with a default value should be required

exceptionfactory · 2026-08-12T21:13:22Z

+    public static final PropertyDescriptor USERNAME = new PropertyDescriptor.Builder()
+            .name("Username")
+            .description("Username to access the Cassandra cluster")
+            .required(false)


Should the Username be required?

exceptionfactory · 2026-08-12T21:16:16Z

+        runner.enableControllerService(sessionProvider);
+
+        verify(sessionProvider, times(1)).connectToCassandra(any(ConfigurationContext.class));
+    }


This test appears to just exercise the spied instance, and should be removed

exceptionfactory · 2026-08-12T21:16:30Z

+        </dependency>
+        <dependency>
+            <groupId>org.apache.nifi</groupId>
+            <artifactId>nifi-ssl-context-service-api</artifactId>


This should be provided

exceptionfactory · 2026-08-12T21:16:41Z

+        <dependency>
+            <groupId>org.apache.nifi</groupId>
+            <artifactId>nifi-framework-api</artifactId>
+            <version>2.10.0-SNAPSHOT</version>
+        </dependency>


This should be removed

exceptionfactory · 2026-08-12T21:16:54Z

+            <groupId>at.yawk.lz4</groupId>
+            <artifactId>lz4-java</artifactId>
+            <version>1.10.4</version>
+        </dependency>


This should be inherited from the parent pom.xml

exceptionfactory · 2026-08-12T21:17:24Z

+            </dependency>
+            <dependency>
+                <groupId>org.apache.cassandra</groupId>
+                <artifactId>java-driver-core</artifactId>


This should be moved down to the Cassandra bundle

mattyb149 · 2026-08-20T13:59:13Z

+import org.apache.nifi.cassandra.exception.CassandraException;
+import org.apache.nifi.cassandra.exception.CassandraExceptionCategory;
+
+public final class DataStaxExceptionMapper {


I'm thinking for posterity we should change references from Datastax to "CassandraDriver"

exceptionfactory

Thanks for the work on this PR @vishal-firgan-ksolves. With the current effort to reintroduce Cassandra support in #11595, I'm closing this PR for now. If there are additional features needed, I recommend building on that effort.

vishal-firgan-ksolves mentioned this pull request Mar 25, 2026

NIFI-15254 Add Cassandra Processors into NiFi 2.x Version. #10773

Closed

12 tasks

exceptionfactory reviewed Mar 27, 2026

View reviewed changes

exceptionfactory requested changes Apr 3, 2026

View reviewed changes

vishal-firgan-ksolves force-pushed the NIFI-15717 branch from 5325d62 to f0d9ff6 Compare April 17, 2026 11:00

vishal-firgan-ksolves added 5 commits May 12, 2026 15:01

NIFI-15717 Add QueryCassandra processor and SessionProvider Controlle…

650eb49

…r Service.

Decouple Cassandra type conversion from AbstractCassandraProcessor

65533ba

NIFI-15717 Fix checkstyle violations

a16f57c

NIFI-15717 Refactor Cassandra processor and service per review feedback.

a8bf50d

NIFI-15717 Update snapshot version

503025a

vishal-firgan-ksolves force-pushed the NIFI-15717 branch from f0d9ff6 to 503025a Compare May 12, 2026 09:36

exceptionfactory requested changes Aug 12, 2026

View reviewed changes

mattyb149 reviewed Aug 20, 2026

View reviewed changes

exceptionfactory requested changes Sep 18, 2026

View reviewed changes

exceptionfactory closed this Sep 18, 2026

	.identifiesControllerService(SSLContextService.class)
	.identifiesControllerService(SSLContextProvider.class)

		.description("Connection timeout. 0 means no timeout. If no value is set, the underlying default will be used.")
		.required(false)

		.description("Read timeout. 0 means no timeout. If no value is set, the underlying default will be used.")
		.required(false)

Conversation

vishal-firgan-ksolves commented Mar 23, 2026

Summary

Components Added

Tracking

Issue Tracking

Pull Request Tracking

Pull Request Formatting

Verification

Build

Licensing

Documentation

Uh oh!

exceptionfactory left a comment

Choose a reason for hiding this comment

Uh oh!

vishal-firgan-ksolves commented Mar 27, 2026

Uh oh!

exceptionfactory left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vishal-firgan-ksolves commented Apr 6, 2026

Uh oh!

vishal-firgan-ksolves commented Apr 16, 2026

Uh oh!

vishal-firgan-ksolves commented May 12, 2026

Uh oh!

exceptionfactory left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

exceptionfactory left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development