Skip to content

NIFI-16351 - Prevent Flow Registry synchronization failures during startup validation - #11684

Open
pvillard31 wants to merge 1 commit into
apache:mainfrom
pvillard31:NIFI-16351
Open

pvillard31 wants to merge 1 commit into
apache:mainfrom
pvillard31:NIFI-16351

Conversation

@pvillard31

Copy link
Copy Markdown
Contributor

Summary

NIFI-16351 - Prevent Flow Registry synchronization failures during startup validation

Flow Registry synchronization can run while a restored Flow Registry Client is still VALIDATING. During startup, client validation cannot begin until flow initialization completes, but version-controlled process groups submit synchronization tasks while the flow is still being restored.

When restoration takes longer than the existing 10-second validation wait, synchronization records a misleading flow-retrieval failure. Recovery then depends on the delayed periodic synchronization task.

This change:

  • Treats VALIDATING as a transient condition without replacing the current synchronization status.
  • Handles INVALID as a durable validation-specific failure.
  • Applies validation-state handling before both registry access paths.
  • Includes the underlying exception message in snapshot-retrieval failures.
  • Submits one Flow Registry synchronization pass after initial validation and after releasing the FlowController write lock.
  • Reuses the same RegistryFlowSynchronizationTask used for periodic synchronization, preserving per-client grouping and interval tracking.
  • Leaves the existing 300-second periodic initial delay and configured synchronization interval unchanged.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant