Repository navigation
Conversation
ffacs
approved these changes
Nov 6, 2026
raulcd
approved these changes
Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Isolate dependency discovery in
orcConfig.cmakewith a CMake variable scope, propagatingorc_FOUNDandorc_NOT_FOUND_MESSAGEwhile keepingCMAKE_MODULE_PATHlocal even on an early return.The patch only changes
c++/orcConfig.cmake.in; it does not modify test CMakeLists files or add test infrastructure.Why are the changes needed?
ORC-2235
find_dependency()returns from the package config when a dependency cannot be found. The previous manual restoration ofCMAKE_MODULE_PATHwas therefore skipped, leaking ORC's module search path into the consuming project.This caused a misleading AWS dependency-discovery failure in Arrow after ORC's LZ4 dependency lookup failed. apache/arrow#55415 adds a caller-side workaround; this PR fixes the underlying ORC configuration leak. It does not change LZ4 dependency-selection policy.
How was this patch tested?
On macOS with CMake 4.3.1:
cmake -S . -B build -DBUILD_JAVA=OFF cmake --build build --target orc-test --parallel 8 cmake --build build --target test-outAfter removing the test-infrastructure changes, both existing CTest tests (
orc-testandtool-test) passed.Separately verified six temporary, out-of-tree configure scenarios with CMake 3.25.2 and 4.3.1: successful/missing dependency discovery with
CMAKE_MODULE_PATHinitially undefined, empty, or containing multiple directories. All six passed with the scoped fix; all three missing-dependency scenarios reproduced the leak against the original template. No regression test files are included in this PR.Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (desktop app 26.1029.61003)