Skip to content

fix(coverage): filter non-project sources from coverage report #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteNicholas merged 3 commits into from
Nov 3, 2026
Merged

fix(coverage): filter non-project sources from coverage report #489

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b19d09
fix(coverage): filter non-project sources from coverage report
lucasfang Nov 2, 2026
dbb2278
fix(coverage): preserve sources under build-like checkout paths
lucasfang Nov 3, 2026
8208bd8
fix(coverage): anchor exclusions to repository paths
lucasfang Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions test/generate_coverage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,32 @@

set -e

cd $(dirname "$0")/../
cd "$(dirname "$0")/../"
repo_root=$PWD
mkdir -p build && cd build
cmake ../ -DCMAKE_BUILD_TYPE=Debug -DPAIMON_BUILD_TESTS=ON -DPAIMON_USE_ASAN=ON -DPAIMON_GENERATE_COVERAGE=ON -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
cmake ../ -DCMAKE_BUILD_TYPE=Debug -DPAIMON_BUILD_TESTS=ON -DPAIMON_USE_ASAN=ON -DPAIMON_GENERATE_COVERAGE=ON -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
-DPAIMON_ENABLE_AVRO=ON -DPAIMON_ENABLE_ORC=ON \
-DPAIMON_ENABLE_MOSAIC=ON -DPAIMON_ENABLE_LANCE=ON -DPAIMON_ENABLE_VORTEX=ON
make -j
make test
lcov --capture --directory src/paimon --directory test --output-file coverage.info
# Keep only project implementation code in the report: drop system headers,
# third-party dependencies from the build tree and third_party/, and test
# sources (*_test.cpp, test helpers, mocks).
# Anchor exclusions to repository paths so checkout ancestors cannot match.
# PWD is the build directory; mocks outside testing/ are listed explicitly.
# Exclusion patterns can overlap or be absent, so unused patterns are nonfatal.
lcov --remove coverage.info \
'/usr/*' \
"$PWD/*" \
"$repo_root/third_party/*" \
"$repo_root/*_test.cpp" \
"$repo_root/test/*" \
"$repo_root/src/paimon/testing/*" \
"$repo_root/src/paimon/rest/mock_rest_server.*" \
--ignore-errors unused \
--output-file coverage_filtered.info
mv coverage_filtered.info coverage.info
genhtml coverage.info --output-directory coverage

ip=$(hostname -I | awk '{print $1}')
Expand Down
Loading