Repository navigation
test(read): cover reader edge cases and clarify build guidance - #495
Merged
lxy-9602 merged 2 commits intoNov 4, 2026
Merged
Conversation
lxy-9602
reviewed
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add regression coverage for late materialization and Parquet page-index filtering, and clarify the README's build requirements and example entry points.
Tests
pre-commit run --files README.md src/paimon/common/reader/late_materializing_file_batch_reader_test.cpp src/paimon/format/parquet/column_index_filter_test.cpp— passed.git diff --checkandgit diff --cached --check— passed before committing.paimon-common-testandpaimon-parquet-format-testsuccessfully withPATH=/home/yonghao.fyh/.cargo/bin:/home/yonghao.fyh/tools/cmake-3.30.0/bin:$PATH RUSTUP_TOOLCHAIN=1.94.0 cmake --build build --target paimon-common-test paimon-parquet-format-test -j 8.LateMaterializingFileBatchReaderTest.*passed 25 tests andColumnIndexFilterTest.*passed 24 tests throughbuild_support/run-test.sh, including all six added cases.read_write_demoandclean_demo, compiled and linked using GCC 10.2.1, C++17, Arrow 17 and the existing Debug Paimon installation. Examples were not executed.The initial test-target rebuild encountered the system Rust 1.67.1 toolchain; using the installed Rust 1.94 toolchain resolved that environment issue. Full unit and integration suites have not been run.
API and Format
No production code, public API, storage format, or protocol changes.
Documentation
Document compiler/CMake requirements, link the build guide, and add read/write and cleanup example links. Adjust feature terminology for consistency.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-6)