Skip to content

test(read): cover reader edge cases and clarify build guidance - #495

Merged
lxy-9602 merged 2 commits into
apache:mainfrom
lucasfang:codex/reader-regressions-and-build-docs
Nov 4, 2026
Merged

lxy-9602 merged 2 commits into
apache:mainfrom
lucasfang:codex/reader-regressions-and-build-docs

Conversation

@lucasfang

@lucasfang lucasfang commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Purpose

Add regression coverage for late materialization and Parquet page-index filtering, and clarify the README's build requirements and example entry points.

  • Cover payload early EOF, empty payload selections, and batches with no selected rows.
  • Cover IN/NOT IN with null literals, missing null counts, and truncated integer bounds.
  • Link the build guide and both standalone examples from the README.

Tests

  • pre-commit run --files README.md src/paimon/common/reader/late_materializing_file_batch_reader_test.cpp src/paimon/format/parquet/column_index_filter_test.cpp — passed.
  • git diff --check and git diff --cached --check — passed before committing.
  • Rebuilt paimon-common-test and paimon-parquet-format-test successfully with PATH=/home/yonghao.fyh/.cargo/bin:/home/yonghao.fyh/tools/cmake-3.30.0/bin:$PATH RUSTUP_TOOLCHAIN=1.94.0 cmake --build build --target paimon-common-test paimon-parquet-format-test -j 8.
  • On the rebuilt binaries, LateMaterializingFileBatchReaderTest.* passed 25 tests and ColumnIndexFilterTest.* passed 24 tests through build_support/run-test.sh, including all six added cases.
  • Both standalone example targets, read_write_demo and clean_demo, compiled and linked using GCC 10.2.1, C++17, Arrow 17 and the existing Debug Paimon installation. Examples were not executed.

The initial test-target rebuild encountered the system Rust 1.67.1 toolchain; using the installed Rust 1.94 toolchain resolved that environment issue. Full unit and integration suites have not been run.

API and Format

No production code, public API, storage format, or protocol changes.

Documentation

Document compiler/CMake requirements, link the build guide, and add read/write and cleanup example links. Adjust feature terminology for consistency.

Generative AI tooling

Generated-by: OpenAI Codex (GPT-6)

Comment thread README.md Resolved

@lxy-9602 lxy-9602 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lxy-9602
lxy-9602 merged commit 2400409 into apache:main Nov 4, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants