Repository navigation
docs: correct license attribution and simplify Vortex comments - #518
Merged
lxy-9602 merged 2 commits intoNov 5, 2026
Merged
Conversation
zjw1111
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Correct the stale ORC read-ahead cache header path in
LICENSE, include the cache configuration header, and add the Vortex 0.75.0 attribution for the callback sink code and upstream patch.Shorten the Vortex callback module's background explanations, repeated ownership descriptions, and test comments while preserving license attribution, FFI contracts, and safety documentation.
Tests
No tests added or test behavior changed. Existing callback I/O tests only have comment edits.
API and Format
No API, storage format, or protocol changes.
Documentation
Updates
LICENSEand inline documentation incrates/vortex_callback_io/callback_io.rs.Validation
pre-commit run --files LICENSE crates/vortex_callback_io/callback_io.rspassed.git diff --checkpassed.Generative AI tooling
Generated-by: OpenAI Codex CLI 0.163.0