Repository navigation
fix(release): backport GCC 13.3 comparator test fix to 0.4 - #532
Merged
SteNicholas merged 1 commit intoNov 6, 2026
Merged
Conversation
(cherry picked from commit df6f7c0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Backport
df6f7c0777c7283052eac2671e1c8e6a96b3fac8(#530) torelease-0.4usingcherry-pick -x.Bind the negated NaN to a typed local variable before constructing the test row's variant. This avoids the GCC 13.3 internal compiler error while preserving the floating-point comparator assertions for both
floatanddouble.Tests
pre-commit run --files src/paimon/common/utils/fields_comparator_test.cpppassed.git diff --check 692cad82f4059e860b41dcee7527fcb09bbdb4df HEADpassed.paimon-common-testtarget built successfully.FieldsComparatorTest.*cases passed, including floating-point ordering forfloatanddouble.cmake --build build-rest --target paimon-common-test -j16 ./build-rest/debug/paimon-common-test --gtest_filter='FieldsComparatorTest.*'The local compiler is GCC 10.2.1; the GCC 13.3-specific compiler failure was not reproduced locally.
API and Format
No public API, production behavior, storage format or protocol changes. This is a test-only compiler workaround.
Documentation
No new feature or configuration option. The test includes the upstream explanation of the GCC workaround.
Generative AI tooling
Generated-by: OpenAI Codex (codex-cli 0.166.0)