Repository navigation
Conversation
9f21d3d to
fc6018f
Compare
| public final class BucketedPrimaryKeyIndexMaintainer { | ||
|
|
||
| @Nullable private final BucketedVectorIndexMaintainer vectorMaintainer; | ||
| private final List<BucketedVectorIndexMaintainer> vectorMaintainers; |
There was a problem hiding this comment.
Renaming this field breaks PrimaryKeyIndexWriteTest.testCreatesCoordinatorForMultipleScalarDefinitionsAndVector, which still calls readField(..., "vectorMaintainer") at line 142. Both Core JDK 8 and JDK 11 CI fail with NoSuchFieldException. Please read vectorMaintainers, assert that the list has one entry, and use its first maintainer for the existing deletion-vector-factory assertion.
There was a problem hiding this comment.
Fixed in 0479ef5. The test now reads vectorMaintainers, asserts that it contains one maintainer, and uses that maintainer for the existing deletion-vector factory assertion. All 19 focused Core tests passed locally on this CR1 head, including the previously failing test (JDK 17).
I also verified the combined head e787eb7, which includes this fix, on JDK 8 (1.8.0_512) and JDK 11 (11.0.27). All 139 focused Core tests passed on each runtime, including this regression test.
|
Requirement fit: SUPPORTED as the concrete lifecycle prerequisite for the implemented multi-column/parallel-build series. I found no additional production lifecycle defect in the own-head rollback, executor replacement, checkpoint/restore, or cleanup paths. I independently reproduced the reflection-test issue already reported above on fc6018f: PrimaryKeyIndexWriteTest.testCreatesCoordinatorForMultipleScalarDefinitionsAndVector throws NoSuchFieldException: vectorMaintainer at line 142. Both Core CI jobs fail on this case. Please include the test correction in this prerequisite commit so each PR builds independently; the later parallel-build PR's correction does not fix this head. Verification: 67 focused Core configuration, lifecycle, writer, compaction/reopen and vector-search tests passed with normal JDK 8 Maven verify. The failing reflection case was run separately and is still a merge blocker. The other inspected Flink 2/Iceberg CI failures are Maven Central HTTP 502 dependency downloads. No duplicate inline finding added. |
fc6018f to
0479ef5
Compare
|
The fix is now included in CR1 itself (0479ef5), and CR2/CR3 have been rebased on it. CR1 no longer depends on CR3 for this test correction. All 19 focused Core tests passed locally on this head, including For additional compatibility coverage, I tested the combined head e787eb7 on JDK 8 (1.8.0_512) and JDK 11 (11.0.27). All 139 focused Core tests passed on each runtime, including the previously failing reflection test. |
Purpose
Related to #10658. Part 1 of the implementation series.
Prepare the primary-key index coordinator to manage multiple vector index
maintainers. Coordinate commit preparation, reverse-order rollback,
executor replacement, and resource cleanup across the maintainers.
Single-column configuration validation remains unchanged. Multiple-column
enablement and bounded parallel builds are covered by the following PRs.
Update the writer test to read the vector maintainer list and preserve
the deletion-vector factory assertion. This regression fix belongs in
this prerequisite commit so it can pass independently.
Tests
PrimaryKeyIndexWriteTest, BucketedPrimaryKeyIndexMaintainerTest,
and PrimaryKeyVectorIndexWriteTest.
remain separate from this local run.