Repository navigation
[flink] Emit the watermark when local merge flushes an empty buffer - #10832
Open
LuciferYang wants to merge 1 commit into
Open
LuciferYang wants to merge 1 commit into
LuciferYang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
close #10831
LocalMergeOperatorholds back the watermark and emits it influshBuffer()after the buffered rows.flushBuffer()returned early when the buffer was empty, so the watermark was not emitted. When records are filtered out before the sink while the source watermark advances, the buffer is empty at every checkpoint, and the snapshot watermark stays where it was when the last record arrived.flushBuffer()now only skips the row output when the buffer is empty and still emits the watermark.Tests
LocalMergeWatermarkITCase#testWatermarkAdvancesWhileRecordsAreFilteredOut: a streaming job writes to a primary key table withlocal-merge-buffer-sizethrough a filter that only lets the first record through, while the source watermark keeps advancing. It waits for the snapshot watermark to advance past its first value. On master it stays at 0 and the test times out; withoutlocal-merge-buffer-sizeit passes on master too.LocalMergeOperatorTest#testEmptyFlushStillEmitsWatermark: a watermark followed byprepareSnapshotPreBarrierwith no records emits the watermark and no rows.API and Format
no
Documentation
no