Repository navigation
[core] Advance index builds across row ID reassignment - #10848
Draft
leaves12138 wants to merge 6 commits into
Draft
leaves12138 wants to merge 6 commits into
leaves12138 wants to merge 6 commits into
Conversation
leaves12138
changed the title
leaves12138
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Global index builds on Data Evolution tables commit as APPEND and currently fail when concurrent row ID reassignment changes their row ranges. Reuse the existing reassignment changes provider for pure index commits, including DELETE+ADD refreshes, so immutable index files can be committed with updated ranges.
Use each ADD output's actual scan baseline and preserve the original source metadata. Validate concurrent indexed-column updates and logical overwrites before reusing a build. Eligibility depends on global index metadata rather than an index-type whitelist. Data-file and changelog commits retain their existing paths and conflict checks; missing required snapshots or reassignment plans still fail directly.
Tests
Extended
CompactReassignReuseTestcovers BTree and Bitmap builds, mixed index scan baselines, DELETE+ADD refreshes, repeated reassignments, failed commit retries, lost successful responses, physical file reuse, point lookups, and rejection of concurrent indexed-column updates.489 relevant core tests passed locally on JDK 8 and on dev2 with JDK 11, including normal Maven checks and existing data-update/automatic-rollback regressions. Native vector queries were not run.