-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[python] BLOB descriptor parsing and read-path compatibility. #9148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Stephen0421
wants to merge
1
commit into
apache:master
Choose a base branch
from
Stephen0421:pypaimon-blob-pr1-foundation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
paimon-python/pypaimon/read/reader/blob_view_read_support.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| """Helpers for eager blob-view/descriptor inline conversion on read.""" | ||
|
|
||
| from typing import List | ||
|
|
||
| from pypaimon.common.options.core_options import CoreOptions | ||
| from pypaimon.read.reader.iface.record_reader import RecordReader | ||
| from pypaimon.schema.data_types import DataField, PyarrowFieldParser | ||
|
|
||
|
|
||
| def needs_blob_inline_convert(table) -> bool: | ||
| view_fields = CoreOptions.blob_view_fields(table.options) | ||
| descriptor_fields = CoreOptions.blob_descriptor_fields(table.options) | ||
| if descriptor_fields: | ||
| # Materialize when blob-as-descriptor=false; otherwise still wrap so | ||
| # merge to_iterator()+get_blob() receives descriptor field metadata. | ||
| return True | ||
| if not view_fields: | ||
| return False | ||
| if CoreOptions.blob_as_descriptor(table.options): | ||
| return True | ||
| return CoreOptions.blob_view_resolve_enabled(table.options) | ||
|
|
||
|
|
||
| def wrap_record_reader_with_blob_inline_convert( | ||
| reader: RecordReader, | ||
| split_read, | ||
| read_fields: List[DataField], | ||
| ) -> RecordReader: | ||
| from pypaimon.read.reader.auth_masking_reader import ( | ||
| BatchToRecordReaderAdapter, RecordReaderToBatchAdapter) | ||
| from pypaimon.read.reader.blob_descriptor_convert_reader import BlobInlineConvertReader | ||
| from pypaimon.read.reader.field_indices import ( | ||
| blob_field_indices, descriptor_field_indices_for_table, vector_field_indices) | ||
|
|
||
| schema = PyarrowFieldParser.from_paimon_schema(read_fields) | ||
| batch_reader = RecordReaderToBatchAdapter(reader, schema) | ||
| batch_reader.file_io = split_read.table.file_io | ||
| batch_reader.blob_field_indices = blob_field_indices(read_fields) | ||
| batch_reader.descriptor_field_indices = descriptor_field_indices_for_table( | ||
| split_read.table, read_fields) | ||
| batch_reader.vector_field_indices = vector_field_indices(read_fields) | ||
| batch_reader = BlobInlineConvertReader( | ||
| batch_reader, | ||
| split_read.table, | ||
| prescan_reader_factory=lambda names: split_read._create_blob_view_prescan_reader(names), | ||
| blob_parallelism=split_read._blob_parallelism, | ||
| ) | ||
| return BatchToRecordReaderAdapter(batch_reader) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Please preserve the typed field metadata when converting this batch reader back to rows.
BatchToRecordReaderAdapter._ArrowBatchIteratorcurrently creates eachOffsetRowwithoutfile_io, BLOB/descriptor/vector indices, or the view lookup. On this newMergeFileSplitReadbridge, a valid descriptor/view BLOB is materialized, butto_iterator()consumers then getTypeError: Field ... is not a BLOB fieldfromrow.get_blob(pos). This is reachable for Java-created primary-key BLOB tables. Please propagate the converted reader metadata into everyOffsetRowand add a merge-readto_iterator() + get_blob()regression test.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
BatchToRecordReaderAdapternow copiesfile_io, BLOB/descriptor/vector indices, and the view lookup into everyOffsetRow.wrap_record_reader_with_blob_inline_convertalso sets that metadata on the batch adapter. Added wrap + adapter roundtrip coverage, including mergeto_iterator() + get_blob().