Skip to content

[core][spark]: support rewrite_manifest procedure - #9195

Draft
zhongyujiang wants to merge 1 commit into
apache:masterfrom
zhongyujiang:rewrite-manifest
Draft

[core][spark]: support rewrite_manifest procedure#9195
zhongyujiang wants to merge 1 commit into
apache:masterfrom
zhongyujiang:rewrite-manifest

Conversation

@zhongyujiang

@zhongyujiang zhongyujiang commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Motivation

Manifest entries are written in commit order, which can become unordered over time. This makes ManifestFileMeta statistics (partitionStats / minBucket / maxBucket / minLevel / maxLevel) loose, reducing manifest-level pruning during scan.

This PR adds a rewrite_manifest Spark procedure that reads all manifest entries, sorts them globally by partition -> bucket -> level -> fileName (canceling ADD/DELETE pairs of the same file), and writes them back as new manifest files with compact statistics.

Usage

CALL sys.rewrite_manifest(table => 'db.table')
CALL sys.rewrite_manifest(table => 'db.table', where => 'dt >= "2024-01-01" AND dt < "2024-02-01"')

An optional where clause restricts the rewrite to manifests whose partition stats may match the predicate; the remaining manifests are left untouched.

Implementation

  • ManifestEntrySortKey: serializable sort key (partition, bucket, level, fileName). Partition stored as byte[] for Kryo compatibility (BinaryRow's Java serialization callbacks are skipped by Kryo). RecordComparator is lazy-initialized per executor.
  • sortByKey + RangePartitioner: same key for ADD and DELETE of the same file guarantees they land in the same Spark partition and can be cancelled.
  • Streaming cancellation: per-key buffer (at most one ADD + one DELETE), order-independent mergeGroup, duplicate detection throws.
  • Single-file writer: each task produces one manifest via createManifestEntryWriter (non-rolling). Empty manifests are deleted.
  • Auto parallelism: floor(estimatedOutputSize / targetSize) - fewer, slightly-over-target manifests preferred over more under-target ones.
  • where clause: Spark expression parsing + transformFieldMapping (full rowType to partitionType index mapping) + PartitionPredicate stats pruning.
  • replaceManifest commit: optimistic concurrency with retry; conflict detection (current base must containAll removed manifests); concurrent delta manifests preserved.

Tests

  • ManifestEntrySortKeyTest (9): partition/bucket/level/fileName ordering, ADD/DELETE same key, serialization survival
  • FileStoreCommitTest (3): identity replace, concurrent delta preservation, concurrent compact conflict
  • RewriteManifestProcedureTest (8): DELETE cleanup, global ordering, where filtering, range where, unpartitioned table, non-partition where throws, size bounds

Add a rewrite_manifest Spark procedure that reads all manifest entries,
sorts them globally by partition -> bucket -> level -> fileName (canceling
ADD/DELETE pairs of the same file along the way) and writes them back as
new manifest files so that ManifestFileMeta statistics become more compact
for scan pruning. The sort runs distributed via a Spark sortByKey shuffle.

- ManifestEntrySortKey: serializable sort key with byte[] partition for
  Kryo compatibility and lazy RecordComparator
- FileStoreCommit#replaceManifest: optimistic-concurrency commit with
  conflict detection (containsAll) and concurrent delta preservation
- RewriteManifestProcedure: distributed sortByKey + streaming
  ADD/DELETE cancellation + where clause + auto parallelism
- FormatTableCommit: add unsupported replaceManifests
- register rewrite_manifest in SparkProcedures
- tests: ManifestEntrySortKeyTest (9), FileStoreCommitTest replaceManifest
  conflict scenarios (3), RewriteManifestProcedureTest (8)

Co-Authored-By: Claude <noreply@anthropic.com>
@zhongyujiang zhongyujiang changed the title [core][spark]: support rewrite_manifest procedure [draft][core][spark]: support rewrite_manifest procedure Aug 12, 2026
@zhongyujiang
zhongyujiang marked this pull request as draft August 12, 2026 12:51
@zhongyujiang zhongyujiang changed the title [draft][core][spark]: support rewrite_manifest procedure [core][spark]: support rewrite_manifest procedure Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant