[common][python] Support SUBSTRING and TRIM in column masking - #9212
Draft
plusplusjiajia wants to merge 2 commits into
Draft
[common][python] Support SUBSTRING and TRIM in column masking#9212plusplusjiajia wants to merge 2 commits into
plusplusjiajia wants to merge 2 commits into
Conversation
plusplusjiajia
force-pushed
the
core-transform-substring-trim-json-serde
branch
3 times, most recently
from
August 13, 2026 17:22
1497502 to
614bd53
Compare
plusplusjiajia
force-pushed
the
core-transform-substring-trim-json-serde
branch
from
August 13, 2026 17:49
614bd53 to
ee0ec60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
SubstringTransformandTrimTransformare not listed inTransform's@JsonSubTypes, so Jackson writes the class simple name as the type id and reading it back fails withInvalidTypeIdException. Both are therefore unusable for column masking, where a rule is stored as JSON and replayed later — the only usable masks today areNULLandCONCATof a constant, so keeping the last four characters of a value cannot be expressed.Registering them needs three more things:
SubstringTransformhad no Jackson annotations, so its inputs were dropped. It gets a@JsonCreatorand a deserializer extendingStringTransform's with a number branch, since its positions may be integers.TrimTransform'strimFlagwas not serialized, andname()returnsTRIMfor all three flags, soLTRIM/RTRIMwould silently degrade intoTRIM. It becomes its own property, and part ofequals/hashCode.Unknown transform typefor both. It gains them, following the Java semantics rather than the nearest Arrow kernel — a one-inputTRIMtrims spaces only, and its character argument is a set.