[common] Fix NullPointerExceptions on null transform inputs - #9214
Open
plusplusjiajia wants to merge 1 commit into
Open
[common] Fix NullPointerExceptions on null transform inputs#9214plusplusjiajia wants to merge 1 commit into
plusplusjiajia wants to merge 1 commit into
Conversation
plusplusjiajia
marked this pull request as ready for review
August 13, 2026 16:56
plusplusjiajia
force-pushed
the
common-transform-null-fixes
branch
from
August 13, 2026 17:51
ab5f184 to
d2fce1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Three
NullPointerExceptions on null transform inputs, all reachable today:TrimTransformreadscharsToTrimwithtoString()before checking it for null, so a null second input throws — even thoughStringUtils.ltrim/rtrim, which it delegates to, already define a nullcharsToTrimas a null result.SubstringTransformreads a begin or length field withInternalRow.getIntwithout anisNullAtcheck. On aGenericRowthat throws; on a columnar row it returns an undefined value, so the rule masks at an arbitrary offset without failing.StringTransform.toStringmaps inputs withObject::toStringand throws on a null input, whichConcatTransformandConcatWsTransformaccept.All three change behaviour only for inputs that previously threw, so no query that previously succeeded changes its result, and nothing about the persisted JSON format changes.