[core] Reuse projected entries in manifest run merge - #9241
Draft
leaves12138 wants to merge 6 commits into
Draft
Conversation
leaves12138
marked this pull request as ready for review
August 15, 2026 18:29
leaves12138
marked this pull request as draft
August 15, 2026 18:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9135 and #9213.
What changed
ProjectedManifestEntry.ENTRY_LAYOUT_PROJECTION.PartitionDictionaryunchanged and reuse it from the nestedManifestEntryRunMerge.SortPartitionDictionary, which only adds concurrent lookup and comparator ranks.MAX_SEQUENCE_NUMBERto the shared entry layout because it is a row-id manifest sorting key.Why
The run-merge implementation duplicated schema layout knowledge with numeric field constants and manual
GenericRowprojection. That made it easy for the optimized sort path to drift from the shared manifest representation and made schema changes require edits in multiple places. This follow-up routes the sort path through the same projected manifest abstraction used by block-aware ordinary merging while keeping sort-specific concurrency and ordering out of the common partition dictionary.Validation
~/bin/check.The output manifest counts and bytes remained unchanged in both benchmark cases.