Repository navigation
Conversation
Motivation: Provide consistent, self-contained formatting across the independent sbt samples. Modification: Configure core Scalafmt and Javafmt versions and style, preserve Scala language modes, include MultiJvm sources, document commands, and apply formatter output. Result: All 17 sbt builds expose working formatting/check commands. Maven-only samples and runtime dependencies remain unchanged. Tests: All 17 applyCodeStyle/checkCodeStyle workflows passed on JDK 17. Cluster Java compile, MultiJvm compile and test passed. Representative Paradox generation passed with a process-local Java 17 compatibility flag. Snippet identities and normalized Java tokens checked; git diff --check passed. Other full test suites and CI were not run. References: Refs apache#206; core formatter configuration at 6049edf9.
He-Pin
force-pushed
the
align-core-formatters
branch
from
November 12, 2026 17:20
af4f9ec to
fb7c0fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Align the independent sbt examples with Apache Pekko core's formatter tooling while keeping each example self-contained.
Modification
applyCodeStyleandcheckCodeStylealiases and document their use.Result
The one-time formatter output touches 29 Java and 25 Scala source files; the remaining changes are tooling/configuration and documentation.
The examples expose consistent, self-contained formatting commands instead of relying on a checkout of the core repository.
Tests
sbt applyCodeStyle checkCodeStylepassed in all 17 independent builds, including all five MultiJvm configurations and the four Java-enabled builds.pekko-sample-cluster-java:compile,MultiJvm / compile, andtestpassed. The distributed MultiJvm suite was compiled, not executed.docs-gen:pekko-sample-cluster-java / paradoxpassed with the process-local JVM flag--add-opens=java.base/java.lang=ALL-UNNAMED, required by its existing Parboiled version on JDK 17. Without that compatibility flag it fails during parser initialization.git diff --checkpassed. No CI inspection/monitoring. Other samples' full test suites were not run; all formatter workflows were exercised.headerCreateAllwas attempted in the representative sample but is unavailable (Not a valid key); no unrelated header plugin was introduced.References
Refs #206: separate existing Scalafix OrganizeImports work; this PR does not add that tooling.
Core reference: apache/pekko 6049edf9.