Conversation
Every build logged 203 assembly-plugin warnings (1385 log lines) caused by stale entries in the assembly descriptors: - 193 "patterns were never triggered": include/exclude patterns that match no artifact. Solr/ES audit destination jars left behind after RANGER-5632 removed those dependencies (solr-solrj, httpasyncclient, httpcore-nio, httpmime, jetty-client); leftovers of the Jersey 1 -> 2 and log4j migrations (hk2, javax.inject, osgi-resource-locator, commons-configuration 1.x, log4j, slf4j-log4j12, noggit); rules that can never match, such as a plugin jar listed in its own dependency filter and excludes with no matching include; and entries in a moduleSet that does not package them. - 10 "filesystem-root relative reference, which is not cross platform compatible": outputDirectory paths starting with "/" in the elasticsearch plugin descriptor. Normalized in the solr, schema-registry and admin-web descriptors as well. A pattern was dropped only when it was unmatched for every module of its moduleSet. Packaging is unchanged: the file listings of all 30 tarballs are identical before and after, both single-threaded and with -T 8. Also fail the build-17 CI job when either warning appears, so stale descriptor entries are caught in review instead of accumulating. A silent symptom of the same warnings is a tarball that quietly loses jars.
kumaab
marked this pull request as draft
September 20, 2026 04:25
kumaab
marked this pull request as ready for review
September 20, 2026 20:47
kumaab
requested review from
mneethiraj,
pradeepagrawal8184 and
ramackri
and removed request for
mneethiraj
September 20, 2026 20:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Every build logged 203 assembly-plugin warnings (1385 log lines) caused by stale entries in the assembly descriptors:
193 "patterns were never triggered": include/exclude patterns that match no artifact. Solr/ES audit destination jars left behind after RANGER-5632 removed those dependencies (solr-solrj, httpasyncclient, httpcore-nio, httpmime, jetty-client); leftovers of the Jersey 1 -> 2 and log4j migrations (hk2, javax.inject, osgi-resource-locator, commons-configuration 1.x, log4j, slf4j-log4j12, noggit); rules that can never match, such as a plugin jar listed in its own dependency filter and excludes with no matching include; and entries in a moduleSet that does not package them.
10 "filesystem-root relative reference, which is not cross platform compatible": outputDirectory paths starting with "/" in the elasticsearch plugin descriptor. Normalized in the solr, schema-registry and admin-web descriptors as well.
A pattern was dropped only when it was unmatched for every module of its moduleSet. Packaging is unchanged: the file listings of all 30 tarballs are identical before and after, both single-threaded and with -T 8.
Also fail the build-17 CI job when either warning appears, so stale descriptor entries are caught in review instead of accumulating. A silent symptom of the same warnings is a tarball that quietly loses jars.
How was this patch tested?
Warnings gone. Same
mvn -T 8 clean packageon master vs this branch:193 "patterns were never triggered" and 10 "filesystem-root relative
reference" warnings drop to 0, which is 1,385 fewer log lines (~63 KB) per build.
Packaging unchanged. Compared this PR's
target-17CI artifact against themasterrun ofd87bd9ee1(the base commit; same Maven and JDK). same tarballs,no entry present on only one side — no jar added, dropped or
renamed.
Removals verified per module. These warnings are logged once per module, so
an entry was removed only when unmatched for every module of its moduleSet.
Descriptors that legitimately need those jars (e.g. Solr jars in
ews/libforadmin and kms) are untouched.
New CI check verified against a deliberate break. Simulated the usual cause
by pinning
commons-ioto an older version inagents-installer/pom.xmlwhilethe descriptors still include
${commons.io.version}:BUILD SUCCESS, with 24 warning blocks, andinstall/lib/commons-io-2.17.0.jarsilently vanished from 13 plugintarballs — installer scripts would fail at runtime.
broke, one line per pattern per archive rather than Maven's per-module
repeats.
target-17artifact is never published and the downstream docker jobs are skipped.
It also correctly stays quiet on pom changes that break nothing: excluding
joda-timefromhdfs-agentproduced no warning, since other modules in thesame moduleSet still supply that jar and it still ships.