[ISSUE #10383] Align Bazel dependencies with Maven pom.xml#10404
Merged
lollipopjin merged 1 commit intoMay 29, 2026
Conversation
8b853ee to
0edc8f9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10404 +/- ##
=============================================
- Coverage 49.09% 47.93% -1.17%
+ Complexity 13507 13253 -254
=============================================
Files 1376 1376
Lines 100537 100536 -1
Branches 12983 12983
=============================================
- Hits 49362 48191 -1171
- Misses 45180 46406 +1226
+ Partials 5995 5939 -56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4706e31 to
1589896
Compare
Replace outdated/incorrect Bazel WORKSPACE artifacts with versions matching Maven source of truth. Key fixes: - Replace rocketmq-rocksdb:1.0.6 with org.rocksdb:rocksdbjni:8.4.4 - Replace org.lz4:lz4-java:1.8.0 with at.yawk.lz4:lz4-java:1.10.3 - Replace bcpkix-jdk15on:1.69 with bcpkix-jdk18on:1.83 - Bump netty-all 4.1.65 -> 4.1.130, guava 31 -> 32, grpc 1.47 -> 1.53 - Bump commons-lang3, commons-io, commons-validator, gson, okio, etc. - Add missing deps: slf4j-api, javassist, grpc-protobuf - Remove duplicate fastjson2 entry - Add --nojava_header_compilation for netty-all POM-only artifact compat - Add Aliyun Maven mirror for faster dependency resolution Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1589896 to
063881f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key Changes
Bazel dependency alignment
org.apache.rocketmq:rocketmq-rocksdb:1.0.6→org.rocksdb:rocksdbjni:8.4.4org.lz4:lz4-java:1.8.0→at.yawk.lz4:lz4-java:1.10.3org.bouncycastle:bcpkix-jdk15on:1.69→bcpkix-jdk18on:1.83slf4j-api:2.0.3,javassist:3.20.0-GA,grpc-protobuf:1.47.0fastjson2entry--nojava_header_compilation(netty-all 4.1.130+ is POM-only)Bug fix: ConfigStorage SIGSEGV
Removed
setDaemon(true)fromConfigStorage.FlushSyncServiceandscheduledExecutorService. The daemon flag causedServiceThread.shutdown()to skipthread.join(), so the flush thread could still be callingdb.flushWal()whenAbstractRocksDBStorage.shutdown()closed the RocksDB native handle — triggering SIGSEGV inrocksdb::log::Writer::WriteBuffer(). Core storage flush threads (like CommitLogGroupCommitService) are non-daemon by convention.Flaky test fixes
RocksDBMessageStoreTestRocksGroupCommitServiceasync flush not complete before CQ readAwaitility.await()to poll until offset is committedIndexStoreServiceTestSystem.currentTimeMillis()~15ms resolution causes timestamp collision increateNewIndexFileReplicasManagerTestsetHaListenPort(0); fixed shutdown orderMotivation
The Bazel CI had been failing with JVM SIGSEGV crashes on RocksDB-related tests. Root cause: WORKSPACE declared
rocketmq-rocksdb:1.0.6(an obsolete shim with mismatched native library) while Maven usesorg.rocksdb:rocksdbjni:8.4.4. The daemon thread issue in ConfigStorage amplified this — even with the correct library, the use-after-free race could still crash.Test plan
bazel build //...passes (583 targets)bazel test //...passes on CI (remote execution)🤖 Generated with Claude Code