Skip to content

SOLR-18242: Replace SolrClientCache with CoreContainer.getDefaultHttpSolrClient in DistribFileStore#4428

Merged
dsmiley merged 5 commits into
apache:mainfrom
jaykay12:SOLR-18242-solrclient-cache-replace
May 15, 2026
Merged

SOLR-18242: Replace SolrClientCache with CoreContainer.getDefaultHttpSolrClient in DistribFileStore#4428
dsmiley merged 5 commits into
apache:mainfrom
jaykay12:SOLR-18242-solrclient-cache-replace

Conversation

@jaykay12
Copy link
Copy Markdown
Contributor

@jaykay12 jaykay12 commented May 15, 2026 •
edited
Loading

https://issues.apache.org/jira/browse/SOLR-18242

Description

Replace SolrClientCache with CoreContainer.getDefaultHttpSolrClient in DistribFileStore

Solution

Replacement done.

Tests

Verified all tests inside "TestDistribFileStore" running successfully in the branch

Screenshot 2026-05-15 at 10 30 56 PM

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide
  • I have added a changelog entry for my change

dsmiley
dsmiley reviewed May 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsmiley dsmiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that was fast turnaround!

See line 406 as well.

IMO the changelog should be dropped as I don't think anyone would notice this tweak.

@jaykay12
Copy link
Copy Markdown
Contributor Author

jaykay12 commented May 15, 2026 •
edited
Loading

Wow that was fast turnaround!

See line 406 as well.

IMO the changelog should be dropped as I don't think anyone would notice this tweak.

  1. understood, have dropped changelog.
  2. missed line 406 back then, did it now.

@jaykay12 jaykay12 requested a review from dsmiley May 15, 2026 17:04
@dsmiley
Copy link
Copy Markdown
Contributor

dsmiley commented May 15, 2026

I'll merge soon; this is a straight-forward change. Thanks again.

@dsmiley dsmiley merged commit 336205f into apache:main May 15, 2026
4 of 6 checks passed
@jaykay12 jaykay12 deleted the SOLR-18242-solrclient-cache-replace branch May 15, 2026 18:56
dsmiley pushed a commit that referenced this pull request May 16, 2026
@jaykay12 @dsmiley
SOLR-18242: DistribFileStore: refactor, don't use SolrClientCache (#4428
680011d 
)

SolrClientCache is only needed to pool CloudSolrClient (different clusters)

(cherry picked from commit 336205f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsmiley dsmiley Awaiting requested review from dsmiley

Assignees

No one assigned

Labels

cat:packagemanager no-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaykay12 @dsmiley