Skip to content

SOLR-18294: Fix flaky IndexFetcherPacketProtocolTest #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shubhamranjan wants to merge 12 commits into
base: main
Choose a base branch
from
+4 −1
Open

SOLR-18294: Fix flaky IndexFetcherPacketProtocolTest #4624

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ce8919f
SOLR-18098: Fix replication failure for files with exact MB sizes
shubhamranjan Mar 10, 2026
c72ea7a
add(SOLR-18098): changelog
shubhamranjan Mar 16, 2026
f5cf54f
Merge branch 'main' of https://github.com/apache/solr
shubhamranjan Mar 16, 2026
aef7e09
fix(SOLR-18098): replace setAccessible with MethodHandles.privateLook…
shubhamranjan Mar 16, 2026
426f032
Merge branch 'main' of https://github.com/apache/solr
shubhamranjan Apr 26, 2026
d58da10
refactor(SOLR-18098): move fix to sender side instead of receiver side
shubhamranjan Apr 26, 2026
b4d7533
nit(SOLR-18098): remove newline
shubhamranjan Apr 26, 2026
22c168d
Merge branch 'main' of https://github.com/apache/solr
shubhamranjan May 28, 2026
9379234
Merge branch 'main' of https://github.com/apache/solr
shubhamranjan Jun 4, 2026
2addb55
Merge branch 'main' of https://github.com/apache/solr
shubhamranjan Jun 23, 2026
0a73c28
SOLR-18294: Fix flaky IndexFetcherPacketProtocolTest
shubhamranjan Jun 28, 2026
2250453
Merge branch 'main' of https://github.com/apache/solr
shubhamranjan Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion solr/core/src/test/org/apache/solr/handler/IndexFetcherPacketProtocolTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,13 @@ private byte[] createDeterministicContent(int size) {
/** Writes file content to a directory and serializes it using the replication packet protocol. */
private byte[] serializeFileToPacketStream(byte[] content, String fileName) throws Exception {
DirectoryFactory directoryFactory = h.getCore().getDirectoryFactory();
// Use the same REPLICATION DirContext that the sender (DirectoryFileStream) uses to read the
// file, so the write and the read target the same (unwrapped) delegate Directory. For
// REPLICATION/BACKUP, CachingDirectoryFactory.filterDirectory() unwraps to the raw delegate.
Directory dir =
directoryFactory.get(
h.getCore().getNewIndexDir(),
DirectoryFactory.DirContext.DEFAULT,
DirectoryFactory.DirContext.REPLICATION,
h.getCore().getSolrConfig().indexConfig.lockType);

try {
Expand Down