SOLR-18160: Deprecate Overseer ADDROLE and REMOVEROLE Collection API operations#4627
Open
abumarjikar wants to merge 4 commits into
Open
SOLR-18160: Deprecate Overseer ADDROLE and REMOVEROLE Collection API operations#4627abumarjikar wants to merge 4 commits into
abumarjikar wants to merge 4 commits into
Conversation
github-actions
Bot
added
the
documentation
dsmiley
reviewed
Jul 10, 2026
| List<String> nodeList = roles.computeIfAbsent(roleName, k -> new ArrayList<>()); | ||
| if (ADDROLE == operation) { | ||
| DeprecationLog.log( | ||
| "CollectionAPI-" + operation.toLower(), |
Contributor
There was a problem hiding this comment.
no-need to change the case of the operation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18160
Description
Deprecate the legacy
ADDROLEandREMOVEROLEOverseer Collection API operations. Users should transition to managing node roles at startup via the-Dsolr.node.rolesparameter.Solution
DeprecationLog.loginOverseerRoleCmd.javafor bothADDROLEandREMOVEROLEoperations, alerting users that they will be removed in Solr 11.@Deprecated(since = "10.1")annotations and updated JavaDoc documentation foraddRoleandremoveRolehelper methods withinCollectionAdminRequest.java.ADDROLEandREMOVEROLEenum entries with@Deprecated(since = "10.1")inCollectionActioninsideCollectionParams.java.Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.