Skip to content

SOLR-18306: Optimize IndexSchema.getDynamicFieldType() by checking cached fields before matching dynamic patterns.#4630

Open
psalagnac wants to merge 2 commits into
apache:mainfrom
psalagnac:optimize-schema
Open

SOLR-18306: Optimize IndexSchema.getDynamicFieldType() by checking cached fields before matching dynamic patterns.#4630
psalagnac wants to merge 2 commits into
apache:mainfrom
psalagnac:optimize-schema

Conversation

@psalagnac

Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/SOLR-18306

Description

This fixes a CPU hotspot in IndexSchema.getDynamicFieldType() by using the cache of dynamic fields before matching all the patterns of dynamic field names.

@dsmiley dsmiley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -0,0 +1,8 @@
title: Optimize IndexSchema.getDynamicFieldType() by checking cached fields before matching dynamic patterns.
type: other

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"changed" for a performance improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants