Repository navigation
Conversation
- satisfies() ignores the prerelease qualifier; add withoutPrerelease() - ZkController version-compat check compares without prerelease - SystemInfoProvider solrImplVersion fallback uses LATEST_STRING Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
dsmiley
force-pushed
the
SOLR-18432-solrversion-prerelease
branch
from
October 28, 2026 00:59
c764fda to
d59169c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 https://issues.apache.org/jira/browse/SOLR-18432
SolrVersionand its callers don't tolerate a prerelease qualifier such as-SNAPSHOT, which blocks makingLATEST_STRINGmatch the build version. This fixes the three breakages first:SolrVersion.satisfies()now evaluates on the version with the prerelease cleared (semver4j otherwise rejects every range for a prerelease), and a newwithoutPrerelease()is added. This unblocksPackageManager's constraint check.compareTo/equalsstay strict semver.ZkController.checkClusterVersionCompatibilitycompares versions without the prerelease, so a dev node is not reported as older than a released node of the same x.y.z. Log and exception messages still print full versions.SystemInfoProviderfalls back toLATEST_STRINGrather thanLATEST.getPrereleaseVersion()forsolrImplVersion.Whether
LATEST_STRINGshould be generated from the Gradle version is left for a follow-up.🤖 Generated with Claude Code