[epugh]

I was too quick on the merge and realized I had some self review comments I had not dealt with.

Summary

Small cleanup follow-up to #4672 (already merged), from a /simplify pass that landed one commit after that PR was squash-merged, so it never made it in.

• Utils.zipDirectory(Path) was shaped around "return bytes for an HTTP body" - fine for its two other callers (CreateTool, DownloadConfigSet), but it forced RemoteSolrBackend.uploadConfigSet to buffer the entire configset zip in memory just to write it straight back out to a temp file it already had open (Files.write(tempZip, Utils.zipDirectory(configDir))). Added a streaming zipDirectory(Path, OutputStream) overload with the shared walk/skip-hidden/normalize-separator logic in one place; the byte[]-returning version now delegates to it, and RemoteSolrBackend calls the streaming form directly against Files.newOutputStream(tempZip), restoring the original single-pass I/O.
• Removed CreateTool.zipConfigSet(Path), a pure one-line passthrough to Utils.zipDirectory with no behavior of its own. Both call sites (the production upload call and CreateToolTest) now call Utils.zipDirectory directly.
• Added a test confirming the two zipDirectory overloads produce equivalent archives - compared by decoded entry name/content rather than raw bytes, since ZipEntry defaults to the current time when none is set explicitly, so two back-to-back calls aren't guaranteed byte-identical.

Test plan

• CreateToolTest, CreateToolPicocliTest, TestSchemaDesignerConfigSetHelper (14 tests) all pass
• Full compileJava/compileTestJava across the repo is clean
• ./gradlew tidy clean
• Verified the commit cherry-picks cleanly onto current main (post-SOLR-18320: Use Configsets V2 API instead of direct ZooKeeper access in bin/solr create #4672 squash-merge) and re-ran the test suite there

🤖 Generated with Claude Code

[epugh]

/no-changelog

[dsmiley]

I wish I had a chance to review. The title says "streaming zipDirectory" but I don't see it. The following method replacement actually streams the zip (meaning, doesn't use an intermediate temp file). I will get this in at some point in the future when I return to SolrBackend stuff:

  public void uploadConfigSet(Path configDir, String name) throws SolrServerException, IOException {
    new ConfigSetAdminRequest.Upload()
        .setConfigSetName(name)
        .setUploadContent(new RequestWriter.ContentWriter() {
          @Override
          public void write(OutputStream os) throws IOException {
            // stream it directly out; no intermediate temp file :-)
            Utils.zipDirectory(configDir, os);
          }

          @Override
          public String getContentType() {
            return "application/zip";
          }
        })
        .process(adminClient);
  }