[SPARK-57140][INFRA] Disable merge button in .asf.yaml#56197
[SPARK-57140][INFRA] Disable merge button in .asf.yaml#56197Yicong-Huang wants to merge 1 commit into
Conversation
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Sorry but -1 because this is a violation of ASF guideline, @Yicong-Huang .
The guideline clearly says one of them must be true.
At least one of squash, merge, or rebase must be true.
When you make a change on ASF infra related stuff, please double check the ASF guideline first. Although this works in a way, you should update the upstream first. In this case, ASF guideline first.
|
You know that we can revisit this PR after revising the upstream, @Yicong-Huang . The upstream ASF guideline is not always true because it's also maintained by human. |
|
Thanks for pointing these out, @dongjoon-hyun. This makes sense, I will close this PR for now. |
|
Thank you! |
What changes were proposed in this pull request?
This PR disables all GitHub merge buttons in
.asf.yamlby settingsquashandrebasetofalse(in addition to the existingmerge: false):Why are the changes needed?
Apache Spark merges pull requests exclusively through the
dev/merge_spark_pr.pyscript, not through GitHub's web UI merge button. The current.asf.yamlstill exposes the Squash and Rebase merge buttons, which can mislead committers into merging a PR directly from the GitHub UI and bypassing the canonical merge tooling. Disabling all merge buttons leaves the merge script as the only supported path to land a PR.Does this PR introduce any user-facing change?
No. This only affects committer-facing repository settings on GitHub.
How was this patch tested?
Not applicable; this is a configuration-only change to
.asf.yaml. The YAML was validated to parse correctly and to set all three merge buttons tofalse.Was this patch authored or co-authored using generative AI tooling?
No.