[SPARK-56661] Fixing MapPartitionsExternalUDF to generate output attributes only once#56206
Open
sven-weber-db wants to merge 1 commit into
Open
[SPARK-56661] Fixing MapPartitionsExternalUDF to generate output attributes only once#56206sven-weber-db wants to merge 1 commit into
sven-weber-db wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up PR on the recently merged 55768. I noticed that the
MapPartitionsExternalUDFre-generates its output attributes on every function call. Instead, we should compute the output attributes once and store them in a local variable. This behavior is fixed by this PR.Why are the changes needed?
The current behavior re-computes the attributes over and over again while they are not expected to change.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit tests for this class.
Was this patch authored or co-authored using generative AI tooling?
No