[Fix] Make WebSocket ServerEndpointExporter conditional to avoid ServerContainer not available - #4501
Open
zhang-arvin wants to merge 1 commit into
Open
Conversation
…erContainer not available (apache#3907)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changes were proposed in this pull request
Make the WebSocket
ServerEndpointExporterbean conditional on thewebsocket.enabledproperty (default:true), so that the application can start gracefully when thejavax.websocket.server.ServerContaineris not available.Why are the changes needed?
When
flink-shaded-hadoop-3-uberjar is placed in thelib/directory, it conflicts with the embedded server's WebSocket implementation, causing theServerContainerto be unavailable. This results in the application failing to start with:This fix makes the WebSocket support optional, allowing users to disable WebSocket by setting
websocket.enabled=falsewhen they encounter classpath conflicts.Fix: #3907
How was this patch tested?
@ConditionalOnPropertyannotation is a standard Spring Boot mechanism that is widely used in the project.websocket.enabledis not set (or set totrue), theServerEndpointExporterbean is created as before.websocket.enabled=false, the bean is not created, and the application starts without WebSocket support. TheMessageServiceImpl.push()method already handles the case where WebSocket is unavailable via try-catch.