[Fix] Fix memory sizes config not taking effect in Yarn mode - #4502
Open
zhang-arvin wants to merge 1 commit into
Open
[Fix] Fix memory sizes config not taking effect in Yarn mode#4502zhang-arvin wants to merge 1 commit into
zhang-arvin wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What problem does this PR solve?
Fixes #3617: The memory sizes configuration in Application Conf (e.g.,
jobmanager.memory.process.size,taskmanager.memory.process.size) was not taking effect when submitting Flink jobs in Yarn mode.Root Cause
In
FlinkClientTrait.prepareConfig(), theappProperties()from the Application Conf (parsed withflink.property.prefix) were never applied to the Flink configuration. WhilesubmitRequest.properties()(dynamic properties from the web UI) were correctly passed as-Dflags viabuildCliArgs(), the Application Conf properties were silently ignored.Fix
Added
applyAppProperties()method inFlinkClientTraitthat applies allappProperties()from the Application Conf to the Flink configuration. This method is called inprepareConfig()afterapplyEnvProperties(), ensuring that all Flink configuration properties set in the Application Conf are properly propagated to the submit request.Changes
applyAppProperties()method toFlinkClientTraitand called it inprepareConfig()SubmitRequestTestcovering memory config parsing from YAML, JSON, and Properties format Application ConfVerification