Skip to content

fix(storage): close Files.walk stream in deleteRepo to stop leak#5575

Closed
justinsiek wants to merge 1 commit into
apache:mainfrom
justinsiek:fix/deleterepo-stream-leak
Closed

fix(storage): close Files.walk stream in deleteRepo to stop leak#5575
justinsiek wants to merge 1 commit into
apache:mainfrom
justinsiek:fix/deleterepo-stream-leak

Conversation

@justinsiek

Copy link
Copy Markdown

Closes #5548

Close Files.walk stream so directory handle is released immediately instead of leaking.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

👋 Thanks for your first contribution to Texera, @justinsiek!

You can drive common housekeeping tasks just by leaving a comment. Type the command on its own line.

On issues

Command What it does
/take Assign the issue to yourself (self-claim it)
/untake Remove yourself as assignee

To find unclaimed work, search is:issue is:open no:assignee — there's no "triage" label; the search filter is the triage state.

Linking sub-issues

Command Where to run it What it does
/sub-issue #12 #13 On the parent Links #12 and #13 as children of this issue
/unsub-issue #12 #13 On the parent Unlinks those children
/parent-issue #5 On the child Sets #5 as this issue's parent
/unparent-issue On the child Removes this issue's parent (auto-detected)
/unparent-issue #5 On the child Removes parent #5 explicitly

You can write references as #12 or bare 12. Cross-repo references like owner/repo#12 aren't supported and are ignored.

On pull requests (author only)

Command What it does
/request-review @user [@user ...] Request reviews from those users
/unrequest-review @user [@user ...] Cancel those review requests

You can mention teams as @org/team, and @copilot works too. Only the PR author can use these commands.

Note: Commands must match exactly — /take this won't work, only /take. Bots are ignored, and you can't self-link an issue or set an issue as its own parent.

For the full contribution flow, see CONTRIBUTING.md.

@codecov-commenter

codecov-commenter commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.16%. Comparing base (564ccdb) to head (8ac3d5f).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...til/dataset/GitVersionControlLocalFileStorage.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5575      +/-   ##
============================================
- Coverage     52.17%   52.16%   -0.02%     
+ Complexity     2482     2478       -4     
============================================
  Files          1068     1068              
  Lines         41311    41312       +1     
  Branches       4439     4439              
============================================
- Hits          21556    21551       -5     
- Misses        18490    18495       +5     
- Partials       1265     1266       +1     
Flag Coverage Δ *Carryforward flag
access-control-service 64.61% <ø> (ø)
agent-service 33.76% <ø> (ø) Carriedforward from 564ccdb
amber 53.25% <0.00%> (-0.04%) ⬇️
computing-unit-managing-service 1.65% <ø> (ø)
config-service 56.06% <ø> (ø)
file-service 38.32% <ø> (ø)
frontend 46.42% <ø> (ø) Carriedforward from 564ccdb
pyamber 90.72% <ø> (ø) Carriedforward from 564ccdb
python 90.75% <ø> (ø) Carriedforward from 564ccdb
workflow-compiling-service 58.69% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Yicong-Huang

Copy link
Copy Markdown
Contributor

Hi @justinsiek please use our PR template. Please feel free to reopen once it is ready. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Close Files.walk stream in GitVersionControlLocalFileStorage.deleteRepo

3 participants