Skip to content

chore(pyright-language-service): remove unused hocon-parser and hoconjs dependencies#5581

Open
yangzhang75 wants to merge 1 commit into
apache:mainfrom
yangzhang75:chore/remove-unused-hocon-deps
Open

chore(pyright-language-service): remove unused hocon-parser and hoconjs dependencies#5581
yangzhang75 wants to merge 1 commit into
apache:mainfrom
yangzhang75:chore/remove-unused-hocon-deps

Conversation

@yangzhang75

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Removes the dead hocon-parser integration from pyright-language-service. The hoconParser call was removed in #3150 (when the language server became a standalone microservice) and the leftover import in #3415, but the two dependencies and the type stub were never cleaned up.

  • Delete src/types/hocon-parser.d.ts (type stub for an unused module)
  • Remove hocon-parser and hoconjs from package.json
  • Regenerate yarn.lock via yarn install

Any related issues, documentation, discussions?

Closes #5442

How was this PR tested?

  • grep -rn "hocon" pyright-language-service/src returns nothing
  • The TypeScript build passes (tsc --noEmit -p tsconfig.json, exit 0)
  • No code in the service imports hocon-parser/hoconjs, so this is a pure dead-code removal

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 4.8)

@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Jun 9, 2026
@xuang7

xuang7 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Could you assign a reviewer for this PR? @chenlica

@Yicong-Huang

Copy link
Copy Markdown
Contributor

I am actually not sure if we still need those files, because we don't have test cases to guard it. Not sure if language service can still work with this change. I don't want to change it like this way unless we have verified it somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused hocon-parser / hoconjs dependencies and type stub from pyright-language-service

3 participants